From 0790df9fd00ba7ab2f7b6dcc3b9d422a02383986 Mon Sep 17 00:00:00 2001 From: Emir Pasic Date: Sun, 7 Aug 2016 01:54:22 +0200 Subject: [PATCH] - errcheck --- README.md | 3 ++- trees/btree/btree.go | 9 ++++++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 0ebd8eb..8e4a1b2 100644 --- a/README.md +++ b/README.md @@ -1237,10 +1237,11 @@ Coding style: # Install tooling and set path: go get github.com/golang/lint/golint go get github.com/fzipp/gocyclo +go get github.com/kisielk/errcheck export PATH=$PATH:$GOPATH/bin # Fix errors and warnings: -go fmt ./... && gofmt -s -w . && go vet ./... && go get ./... && go test ./... && golint ./... && gocyclo -avg -over 15 . +go fmt ./... && gofmt -s -w . && go vet ./... && go get ./... && go test ./... && golint ./... && gocyclo -avg -over 15 . && errcheck ./... ``` ### License diff --git a/trees/btree/btree.go b/trees/btree/btree.go index 549684f..5f86699 100644 --- a/trees/btree/btree.go +++ b/trees/btree/btree.go @@ -191,7 +191,8 @@ func (tree *Tree) RightValue() interface{} { // String returns a string representation of container (for debugging purposes) func (tree *Tree) String() string { var buffer bytes.Buffer - buffer.WriteString("BTree\n") + if _, err := buffer.WriteString("BTree\n"); err != nil { + } if !tree.Empty() { tree.output(&buffer, tree.Root, 0, true) } @@ -208,8 +209,10 @@ func (tree *Tree) output(buffer *bytes.Buffer, node *Node, level int, isTail boo tree.output(buffer, node.Children[e], level+1, true) } if e < len(node.Entries) { - buffer.WriteString(strings.Repeat(" ", level)) - buffer.WriteString(fmt.Sprintf("%v", node.Entries[e].Key) + "\n") + if _, err := buffer.WriteString(strings.Repeat(" ", level)); err != nil { + } + if _, err := buffer.WriteString(fmt.Sprintf("%v", node.Entries[e].Key) + "\n"); err != nil { + } } } }