From 9bb9b6e7219b96bb633d85d0d5d1048f073822bc Mon Sep 17 00:00:00 2001 From: YangHau Date: Fri, 12 Jul 2019 16:38:40 +0800 Subject: [PATCH] Remove redundant initialization in clients the `memset(&cfg, 0, sizeof(struct mosq_config));` already exsits in `client_config_load()`'s `init_config()` function call. So calling it in main function is totally unnecessary. Signed-off-by: YangHau --- client/pub_client.c | 1 - client/rr_client.c | 2 -- client/sub_client.c | 2 -- 3 files changed, 5 deletions(-) diff --git a/client/pub_client.c b/client/pub_client.c index 31740391..62c79921 100644 --- a/client/pub_client.c +++ b/client/pub_client.c @@ -443,7 +443,6 @@ int main(int argc, char *argv[]) if(pub_shared_init()) return 1; - memset(&cfg, 0, sizeof(struct mosq_config)); rc = client_config_load(&cfg, CLIENT_PUB, argc, argv); if(rc){ if(rc == 2){ diff --git a/client/rr_client.c b/client/rr_client.c index 6444c28e..02801e82 100644 --- a/client/rr_client.c +++ b/client/rr_client.c @@ -252,8 +252,6 @@ int main(int argc, char *argv[]) #ifndef WIN32 struct sigaction sigact; #endif - - memset(&cfg, 0, sizeof(struct mosq_config)); mosquitto_lib_init(); diff --git a/client/sub_client.c b/client/sub_client.c index f57a48cc..a279b249 100644 --- a/client/sub_client.c +++ b/client/sub_client.c @@ -278,8 +278,6 @@ int main(int argc, char *argv[]) #ifndef WIN32 struct sigaction sigact; #endif - - memset(&cfg, 0, sizeof(struct mosq_config)); mosquitto_lib_init();