From 18f0508a6edeee5307d41ab9f57f33bd1cdc2037 Mon Sep 17 00:00:00 2001
From: "Roger A. Light" <roger@atchoo.org>
Date: Thu, 23 Jan 2020 10:07:56 +0000
Subject: [PATCH] Fix dereference before null check.

Coverity Scan 1405815.
---
 src/mosquitto.c | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/src/mosquitto.c b/src/mosquitto.c
index 8969f03f..032afb26 100644
--- a/src/mosquitto.c
+++ b/src/mosquitto.c
@@ -332,6 +332,10 @@ int main(int argc, char *argv[])
 #endif
 		}
 	}
+	if(listensock == NULL){
+		log__printf(NULL, MOSQ_LOG_ERR, "Error: Unable to start any listening sockets, exiting.");
+		return 1;
+	}
 
 	rc = drop_privileges(&config, false);
 	if(rc != MOSQ_ERR_SUCCESS) return rc;
@@ -416,18 +420,16 @@ int main(int argc, char *argv[])
 
 	db__close(&int_db);
 
-	if(listensock){
-		for(i=0; i<listensock_count; i++){
-			if(listensock[i] != INVALID_SOCKET){
+	for(i=0; i<listensock_count; i++){
+		if(listensock[i] != INVALID_SOCKET){
 #ifndef WIN32
-				close(listensock[i]);
+			close(listensock[i]);
 #else
-				closesocket(listensock[i]);
+			closesocket(listensock[i]);
 #endif
-			}
 		}
-		mosquitto__free(listensock);
 	}
+	mosquitto__free(listensock);
 
 	mosquitto_security_module_cleanup(&int_db);