From 1a0240b5d5c3db14e83e1dfa2c81acad5052def8 Mon Sep 17 00:00:00 2001
From: "Roger A. Light" <roger@atchoo.org>
Date: Sun, 12 Feb 2017 21:22:58 +0000
Subject: [PATCH] [379] Improve mosquitto_passwd error messages.

Thanks to Jaimyn Mayer. Closes #379.

Bug: https://github.com/eclipse/mosquitto/issues/379
---
 ChangeLog.txt          |  1 +
 src/mosquitto_passwd.c | 57 ++++++++++++++++++++++++++----------------
 2 files changed, 37 insertions(+), 21 deletions(-)

diff --git a/ChangeLog.txt b/ChangeLog.txt
index 00dd0704..c03ad2bc 100644
--- a/ChangeLog.txt
+++ b/ChangeLog.txt
@@ -6,6 +6,7 @@ Broker:
 - For http only websockets clients, close files served over http in all cases
   when the client disconnects. Closes #354.
 - Fix error message when websockets http_dir directory does not exist.
+- Improve password utility error message. Closes #379.
 
 Client library:
 - Clients can now use TLS with IPv6.
diff --git a/src/mosquitto_passwd.c b/src/mosquitto_passwd.c
index de9a719a..aa7a8101 100644
--- a/src/mosquitto_passwd.c
+++ b/src/mosquitto_passwd.c
@@ -377,35 +377,50 @@ int main(int argc, char *argv[])
 
 	OpenSSL_add_all_digests();
 
-	if(argc == 5){
-		if(!strcmp(argv[1], "-b")){
-			batch_mode = true;
-		}else{
-			fprintf(stderr, "Error: Unknown option '%s'\n", argv[1]);
+	if(argc == 1){
+		print_usage();
+		return 1;
+	}
+
+	if(!strcmp(argv[1], "-c")){
+		create_new = true;
+		if(argc != 4){
+			fprintf(stderr, "Error: -c argument given but password file or username missing.\n");
 			return 1;
+		}else{
+			password_file_tmp = argv[2];
+			username = argv[3];
 		}
-		password_file_tmp = argv[2];
-		username = argv[3];
-		password_cmd = argv[4];
-	}else if(argc == 4){
-		if(!strcmp(argv[1], "-c")){
-			create_new = true;
-		}else if(!strcmp(argv[1], "-D")){
-			delete_user = true;
+	}else if(!strcmp(argv[1], "-D")){
+		delete_user = true;
+		if(argc != 4){
+			fprintf(stderr, "Error: -D argument given but password file or username missing.\n");
+			return 1;
 		}else{
-			fprintf(stderr, "Error: Unknown option '%s'\n", argv[1]);
+			password_file_tmp = argv[2];
+			username = argv[3];
+		}
+	}else if(!strcmp(argv[1], "-b")){
+		batch_mode = true;
+		if(argc != 5){
+			fprintf(stderr, "Error: -b argument given but password file, username or password missing.\n");
 			return 1;
+		}else{
+			password_file_tmp = argv[2];
+			username = argv[3];
+			password_cmd = argv[4];
 		}
-		password_file_tmp = argv[2];
-		username = argv[3];
-	}else if(argc == 3){
-		if(!strcmp(argv[1], "-U")){
+	}else if(!strcmp(argv[1], "-U")){
+		if(argc != 3){
+			fprintf(stderr, "Error: -U argument given but password file missing.\n");
+			return 1;
+		}else{
 			do_update_file = true;
 			password_file_tmp = argv[2];
-		}else{
-			password_file_tmp = argv[1];
-			username = argv[2];
 		}
+	}else if(argc == 3){
+		password_file_tmp = argv[1];
+		username = argv[2];
 	}else{
 		print_usage();
 		return 1;