From 30d8d2ba6b211103c769e95194c2bd0cf11c6237 Mon Sep 17 00:00:00 2001 From: "Roger A. Light" Date: Sun, 5 Feb 2023 23:30:10 +0000 Subject: [PATCH] Fix leak on error. Closes oss-fuzz #55723. This was a leak on a failure case which would have caused the program to terminate. --- src/persist_read_v5.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/persist_read_v5.c b/src/persist_read_v5.c index ab88d817..48502d2d 100644 --- a/src/persist_read_v5.c +++ b/src/persist_read_v5.c @@ -128,7 +128,10 @@ int persist__chunk_client_msg_read_v56(FILE *db_fptr, struct P_client_msg *chunk if(length > 0){ prop_packet.remaining_length = length; prop_packet.payload = mosquitto__malloc(length); - if(!prop_packet.payload) return MOSQ_ERR_NOMEM; + if(!prop_packet.payload){ + errno = ENOMEM; + goto error; + } read_e(db_fptr, prop_packet.payload, length); rc = property__read_all(CMD_PUBLISH, &prop_packet, &properties);