From 598b1d7b00bc460add90d43ffafc84660696224e Mon Sep 17 00:00:00 2001
From: "Roger A. Light" <roger@atchoo.org>
Date: Thu, 26 Nov 2020 15:11:20 +0000
Subject: [PATCH] dynsec: Fix free on modifyClient.

---
 plugins/dynamic-security/clients.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plugins/dynamic-security/clients.c b/plugins/dynamic-security/clients.c
index c0496493..5ab3f38c 100644
--- a/plugins/dynamic-security/clients.c
+++ b/plugins/dynamic-security/clients.c
@@ -700,10 +700,10 @@ int dynsec_clients__process_modify(cJSON *j_responses, struct mosquitto *context
 				dynsec__command_reply(j_responses, context, "modifyClient", "Internal error", correlation_data);
 				return MOSQ_ERR_NOMEM;
 			}
-			mosquitto_free(client->clientid);
 		}else{
 			str = NULL;
 		}
+		mosquitto_free(client->clientid);
 		client->clientid = str;
 	}