Fix clients being disconnected when ACLs are in use.

This only affects the case where a client connects using a username, and
the anonymous ACL list is defined but specific user ACLs are not
defined.

Closes #1162. Thanks to quonb.

ChangeLog.txt

@@ -1,3 +1,12 @@
+1.5.8 - 2019xxxx
+================
+
+Broker:
+- Fix clients being disconnected when ACLs are in use. This only affects the
+  case where a client connects using a username, and the anonymous ACL list is
+  defined but specific user ACLs are not defined. Closes #1162.
+
+
 1.5.7 - 20190213
 ================
 

src/security_default.c

@@ -642,9 +642,6 @@ int acl__find_acls(struct mosquitto_db *db, struct mosquitto *context)
 			}
 			acl_tail = acl_tail->next;
 		}
-		if(context->username && context->acl_list == NULL){
-			return MOSQ_ERR_INVAL;
-		}
 	}else{
 		context->acl_list = NULL;
 	}

test/broker/Makefile

@@ -121,6 +121,7 @@ endif
 endif
 
 09 :
+	./09-acl-access-variants.py
 	./09-acl-empty-file.py
 	./09-plugin-auth-unpwd-success.py
 	./09-plugin-auth-unpwd-fail.py

test/broker/ptest.py

@@ -93,6 +93,7 @@ tests = [
     (2, './08-tls-psk-pub.py'),
     (3, './08-tls-psk-bridge.py'),
 
+    (1, './09-acl-access-variants.py'),
     (1, './09-acl-empty-file.py'),
     (1, './09-plugin-auth-unpwd-success.py'),
     (1, './09-plugin-auth-unpwd-fail.py'),