From c5ba59758804252bd358c5830705635a3f3479de Mon Sep 17 00:00:00 2001 From: "Roger A. Light" Date: Fri, 6 Nov 2020 11:19:27 +0000 Subject: [PATCH] Fix use after free (unreleased) --- src/database.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/database.c b/src/database.c index b7a39f9b..17058961 100644 --- a/src/database.c +++ b/src/database.c @@ -1018,10 +1018,10 @@ static int db__message_write_inflight_out_single(struct mosquitto_db *db, struct } if(now > msg->store->message_expiry_time){ /* Message is expired, must not send. */ - db__message_remove(db, &context->msgs_out, msg); if(msg->direction == mosq_md_out && msg->qos > 0){ util__increment_send_quota(context); } + db__message_remove(db, &context->msgs_out, msg); return MOSQ_ERR_SUCCESS; }else{ expiry_interval = (uint32_t)(msg->store->message_expiry_time - now);