From caeb211cc5efdbb3755c4fd9bc68c83151c35de5 Mon Sep 17 00:00:00 2001 From: Panagiotis Vasilikos Date: Tue, 28 Jan 2020 11:34:11 +0100 Subject: [PATCH] Memory leak in socks_mosq.c Reason: The memory allocated for the packet pointer at line 155 is not freed before returning at line 188. Fix: I inserted the mosquitto__free(packet) statement just before returning at line 188. Signed-off-by: Panagiotis Vasilikos --- lib/socks_mosq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/socks_mosq.c b/lib/socks_mosq.c index a9f0bbcd..bb651592 100644 --- a/lib/socks_mosq.c +++ b/lib/socks_mosq.c @@ -185,6 +185,7 @@ int socks5__send(struct mosquitto *mosq) }else{ slen = strlen(mosq->host); if(slen > UCHAR_MAX){ + mosquitto__free(packet); return MOSQ_ERR_NOMEM; } packet->packet_length = 7 + slen;