Property reading, and tests for byte properties.
Roger A. Light
7 years ago
parent
34c8c28e9d
commit
f4b2838574
@ -0,0 +1,390 @@
|
||||
#include <CUnit/CUnit.h>
|
||||
#include <CUnit/Basic.h>
|
||||
|
||||
#include "mqtt_protocol.h"
|
||||
#include "property_mosq.h"
|
||||
#include "packet_mosq.h"
|
||||
|
||||
static void byte_prop_read_helper(
|
||||
uint8_t *payload,
|
||||
int remaining_length,
|
||||
int rc_expected,
|
||||
int identifier,
|
||||
uint8_t value_expected)
|
||||
{
|
||||
struct mosquitto__packet packet;
|
||||
struct mqtt5__property *properties;
|
||||
int rc;
|
||||
|
||||
memset(&packet, 0, sizeof(struct mosquitto__packet));
|
||||
packet.payload = payload;
|
||||
packet.remaining_length = remaining_length;
|
||||
rc = property__read_all(&packet, &properties);
|
||||
|
||||
CU_ASSERT_EQUAL(rc, rc_expected);
|
||||
CU_ASSERT_EQUAL(packet.pos, remaining_length);
|
||||
if(properties){
|
||||
CU_ASSERT_EQUAL(properties->identifier, identifier);
|
||||
CU_ASSERT_EQUAL(properties->value.i8, value_expected);
|
||||
CU_ASSERT_PTR_EQUAL(properties->next, NULL);
|
||||
property__free_all(&properties);
|
||||
}
|
||||
CU_ASSERT_PTR_EQUAL(properties, NULL);
|
||||
}
|
||||
|
||||
static void duplicate_byte_helper(int identifier)
|
||||
{
|
||||
uint8_t payload[20];
|
||||
|
||||
memset(&payload, 0, sizeof(payload));
|
||||
payload[0] = 4; /* Proplen = (Identifier + byte)*2 */
|
||||
payload[1] = identifier;
|
||||
payload[2] = 1;
|
||||
payload[3] = identifier;
|
||||
payload[4] = 0;
|
||||
|
||||
byte_prop_read_helper(payload, 5, MOSQ_ERR_PROTOCOL, identifier, 1);
|
||||
}
|
||||
|
||||
static void bad_byte_helper(int identifier)
|
||||
{
|
||||
uint8_t payload[20];
|
||||
|
||||
memset(&payload, 0, sizeof(payload));
|
||||
payload[0] = 2; /* Proplen = Identifier + byte */
|
||||
payload[1] = identifier;
|
||||
payload[2] = 2; /* 0, 1 are only valid values */
|
||||
|
||||
byte_prop_read_helper(payload, 3, MOSQ_ERR_PROTOCOL, identifier, 0);
|
||||
}
|
||||
|
||||
|
||||
/* ========================================================================
|
||||
* NO PROPERTIES
|
||||
* ======================================================================== */
|
||||
|
||||
static void TEST_no_properties(void)
|
||||
{
|
||||
struct mosquitto__packet packet;
|
||||
struct mqtt5__property *properties = NULL;
|
||||
uint8_t payload[5];
|
||||
int rc;
|
||||
|
||||
memset(&packet, 0, sizeof(struct mosquitto__packet));
|
||||
memset(payload, 0, sizeof(payload));
|
||||
packet.payload = payload;
|
||||
packet.remaining_length = 1;
|
||||
rc = property__read_all(&packet, &properties);
|
||||
CU_ASSERT_EQUAL(rc, MOSQ_ERR_SUCCESS);
|
||||
CU_ASSERT_PTR_EQUAL(properties, NULL);
|
||||
CU_ASSERT_EQUAL(packet.pos, 1);
|
||||
}
|
||||
|
||||
static void TEST_truncated(void)
|
||||
{
|
||||
struct mosquitto__packet packet;
|
||||
struct mqtt5__property *properties = NULL;
|
||||
uint8_t payload[5];
|
||||
int rc;
|
||||
|
||||
/* Zero length packet */
|
||||
memset(&packet, 0, sizeof(struct mosquitto__packet));
|
||||
memset(payload, 0, sizeof(payload));
|
||||
packet.payload = payload;
|
||||
packet.remaining_length = 0;
|
||||
rc = property__read_all(&packet, &properties);
|
||||
CU_ASSERT_EQUAL(rc, MOSQ_ERR_PROTOCOL);
|
||||
CU_ASSERT_PTR_EQUAL(properties, NULL);
|
||||
CU_ASSERT_EQUAL(packet.pos, 0);
|
||||
|
||||
/* Proplen > 0 but not enough data */
|
||||
memset(&packet, 0, sizeof(struct mosquitto__packet));
|
||||
memset(payload, 0, sizeof(payload));
|
||||
payload[0] = 2;
|
||||
packet.payload = payload;
|
||||
packet.remaining_length = 1;
|
||||
rc = property__read_all(&packet, &properties);
|
||||
CU_ASSERT_EQUAL(rc, MOSQ_ERR_PROTOCOL);
|
||||
CU_ASSERT_PTR_EQUAL(properties, NULL);
|
||||
CU_ASSERT_EQUAL(packet.pos, 1);
|
||||
|
||||
/* Proplen > 0 but not enough data */
|
||||
memset(&packet, 0, sizeof(struct mosquitto__packet));
|
||||
memset(payload, 0, sizeof(payload));
|
||||
payload[0] = 4;
|
||||
payload[1] = PROP_PAYLOAD_FORMAT_INDICATOR;
|
||||
packet.payload = payload;
|
||||
packet.remaining_length = 2;
|
||||
rc = property__read_all(&packet, &properties);
|
||||
CU_ASSERT_EQUAL(rc, MOSQ_ERR_PROTOCOL);
|
||||
CU_ASSERT_PTR_EQUAL(properties, NULL);
|
||||
CU_ASSERT_EQUAL(packet.pos, 2);
|
||||
}
|
||||
|
||||
/* ========================================================================
|
||||
* INVALID PROPERTY ID
|
||||
* ======================================================================== */
|
||||
|
||||
static void TEST_invalid_property_id(void)
|
||||
{
|
||||
struct mosquitto__packet packet;
|
||||
struct mqtt5__property *properties = NULL;
|
||||
uint8_t payload[5];
|
||||
int rc;
|
||||
|
||||
/* ID = 0 */
|
||||
memset(&packet, 0, sizeof(struct mosquitto__packet));
|
||||
memset(payload, 0, sizeof(payload));
|
||||
payload[0] = 4;
|
||||
packet.payload = payload;
|
||||
packet.remaining_length = 2;
|
||||
rc = property__read_all(&packet, &properties);
|
||||
CU_ASSERT_EQUAL(rc, MOSQ_ERR_MALFORMED_PACKET);
|
||||
CU_ASSERT_PTR_EQUAL(properties, NULL);
|
||||
CU_ASSERT_EQUAL(packet.pos, 2);
|
||||
|
||||
/* ID = 4 */
|
||||
memset(&packet, 0, sizeof(struct mosquitto__packet));
|
||||
memset(payload, 0, sizeof(payload));
|
||||
payload[0] = 4;
|
||||
payload[1] = 4;
|
||||
packet.payload = payload;
|
||||
packet.remaining_length = 2;
|
||||
rc = property__read_all(&packet, &properties);
|
||||
CU_ASSERT_EQUAL(rc, MOSQ_ERR_MALFORMED_PACKET);
|
||||
CU_ASSERT_PTR_EQUAL(properties, NULL);
|
||||
CU_ASSERT_EQUAL(packet.pos, 2);
|
||||
}
|
||||
|
||||
/* ========================================================================
|
||||
* SINGLE PROPERTIES
|
||||
* ======================================================================== */
|
||||
|
||||
static void TEST_single_payload_format_indicator(void)
|
||||
{
|
||||
uint8_t payload[20];
|
||||
|
||||
memset(&payload, 0, sizeof(payload));
|
||||
payload[0] = 2; /* Proplen = Identifier + byte */
|
||||
payload[1] = PROP_PAYLOAD_FORMAT_INDICATOR;
|
||||
payload[2] = 1;
|
||||
|
||||
byte_prop_read_helper(payload, 3, MOSQ_ERR_SUCCESS, PROP_PAYLOAD_FORMAT_INDICATOR, 1);
|
||||
}
|
||||
|
||||
static void TEST_single_request_problem_information(void)
|
||||
{
|
||||
uint8_t payload[20];
|
||||
|
||||
memset(&payload, 0, sizeof(payload));
|
||||
payload[0] = 2; /* Proplen = Identifier + byte */
|
||||
payload[1] = PROP_REQUEST_PROBLEM_INFO;
|
||||
payload[2] = 1;
|
||||
|
||||
byte_prop_read_helper(payload, 3, MOSQ_ERR_SUCCESS, PROP_REQUEST_PROBLEM_INFO, 1);
|
||||
}
|
||||
|
||||
static void TEST_single_request_response_information(void)
|
||||
{
|
||||
uint8_t payload[20];
|
||||
|
||||
memset(&payload, 0, sizeof(payload));
|
||||
payload[0] = 2; /* Proplen = Identifier + byte */
|
||||
payload[1] = PROP_REQUEST_RESPONSE_INFO;
|
||||
payload[2] = 1;
|
||||
|
||||
byte_prop_read_helper(payload, 3, MOSQ_ERR_SUCCESS, PROP_REQUEST_RESPONSE_INFO, 1);
|
||||
}
|
||||
|
||||
static void TEST_single_maximum_qos(void)
|
||||
{
|
||||
uint8_t payload[20];
|
||||
|
||||
memset(&payload, 0, sizeof(payload));
|
||||
payload[0] = 2; /* Proplen = Identifier + byte */
|
||||
payload[1] = PROP_MAXIMUM_QOS;
|
||||
payload[2] = 1;
|
||||
|
||||
byte_prop_read_helper(payload, 3, MOSQ_ERR_SUCCESS, PROP_MAXIMUM_QOS, 1);
|
||||
}
|
||||
|
||||
static void TEST_single_retain_available(void)
|
||||
{
|
||||
uint8_t payload[20];
|
||||
|
||||
memset(&payload, 0, sizeof(payload));
|
||||
payload[0] = 2; /* Proplen = Identifier + byte */
|
||||
payload[1] = PROP_RETAIN_AVAILABLE;
|
||||
payload[2] = 1;
|
||||
|
||||
byte_prop_read_helper(payload, 3, MOSQ_ERR_SUCCESS, PROP_RETAIN_AVAILABLE, 1);
|
||||
}
|
||||
|
||||
static void TEST_single_wildcard_subscription_available(void)
|
||||
{
|
||||
uint8_t payload[20];
|
||||
|
||||
memset(&payload, 0, sizeof(payload));
|
||||
payload[0] = 2; /* Proplen = Identifier + byte */
|
||||
payload[1] = PROP_WILDCARD_SUB_AVAILABLE;
|
||||
payload[2] = 0;
|
||||
|
||||
byte_prop_read_helper(payload, 3, MOSQ_ERR_SUCCESS, PROP_WILDCARD_SUB_AVAILABLE, 0);
|
||||
}
|
||||
|
||||
static void TEST_single_subscription_identifier_available(void)
|
||||
{
|
||||
uint8_t payload[20];
|
||||
|
||||
memset(&payload, 0, sizeof(payload));
|
||||
payload[0] = 2; /* Proplen = Identifier + byte */
|
||||
payload[1] = PROP_SUBSCRIPTION_ID_AVAILABLE;
|
||||
payload[2] = 0;
|
||||
|
||||
byte_prop_read_helper(payload, 3, MOSQ_ERR_SUCCESS, PROP_SUBSCRIPTION_ID_AVAILABLE, 0);
|
||||
}
|
||||
|
||||
static void TEST_single_shared_subscription_available(void)
|
||||
{
|
||||
uint8_t payload[20];
|
||||
|
||||
memset(&payload, 0, sizeof(payload));
|
||||
payload[0] = 2; /* Proplen = Identifier + byte */
|
||||
payload[1] = PROP_SHARED_SUB_AVAILABLE;
|
||||
payload[2] = 1;
|
||||
|
||||
byte_prop_read_helper(payload, 3, MOSQ_ERR_SUCCESS, PROP_SHARED_SUB_AVAILABLE, 1);
|
||||
}
|
||||
|
||||
/* ========================================================================
|
||||
* DUPLICATE PROPERTIES
|
||||
* ======================================================================== */
|
||||
|
||||
static void TEST_duplicate_payload_format_indicator(void)
|
||||
{
|
||||
duplicate_byte_helper(PROP_PAYLOAD_FORMAT_INDICATOR);
|
||||
}
|
||||
|
||||
static void TEST_duplicate_request_problem_information(void)
|
||||
{
|
||||
duplicate_byte_helper(PROP_REQUEST_PROBLEM_INFO);
|
||||
}
|
||||
|
||||
static void TEST_duplicate_request_response_information(void)
|
||||
{
|
||||
duplicate_byte_helper(PROP_REQUEST_RESPONSE_INFO);
|
||||
}
|
||||
|
||||
static void TEST_duplicate_maximum_qos(void)
|
||||
{
|
||||
duplicate_byte_helper(PROP_MAXIMUM_QOS);
|
||||
}
|
||||
|
||||
static void TEST_duplicate_retain_available(void)
|
||||
{
|
||||
duplicate_byte_helper(PROP_RETAIN_AVAILABLE);
|
||||
}
|
||||
|
||||
static void TEST_duplicate_wildcard_subscription_available(void)
|
||||
{
|
||||
duplicate_byte_helper(PROP_WILDCARD_SUB_AVAILABLE);
|
||||
}
|
||||
|
||||
static void TEST_duplicate_subscription_identifier_available(void)
|
||||
{
|
||||
duplicate_byte_helper(PROP_SUBSCRIPTION_ID_AVAILABLE);
|
||||
}
|
||||
|
||||
static void TEST_duplicate_shared_subscription_available(void)
|
||||
{
|
||||
duplicate_byte_helper(PROP_SHARED_SUB_AVAILABLE);
|
||||
}
|
||||
|
||||
/* ========================================================================
|
||||
* BAD PROPERTY VALUES
|
||||
* ======================================================================== */
|
||||
|
||||
static void TEST_bad_request_problem_information(void)
|
||||
{
|
||||
bad_byte_helper(PROP_REQUEST_PROBLEM_INFO);
|
||||
}
|
||||
|
||||
static void TEST_bad_request_response_information(void)
|
||||
{
|
||||
bad_byte_helper(PROP_REQUEST_RESPONSE_INFO);
|
||||
}
|
||||
|
||||
static void TEST_bad_maximum_qos(void)
|
||||
{
|
||||
bad_byte_helper(PROP_MAXIMUM_QOS);
|
||||
}
|
||||
|
||||
static void TEST_bad_retain_available(void)
|
||||
{
|
||||
bad_byte_helper(PROP_RETAIN_AVAILABLE);
|
||||
}
|
||||
|
||||
static void TEST_bad_wildcard_sub_available(void)
|
||||
{
|
||||
bad_byte_helper(PROP_WILDCARD_SUB_AVAILABLE);
|
||||
}
|
||||
|
||||
static void TEST_bad_subscription_id_available(void)
|
||||
{
|
||||
bad_byte_helper(PROP_SUBSCRIPTION_ID_AVAILABLE);
|
||||
}
|
||||
|
||||
static void TEST_bad_shared_sub_available(void)
|
||||
{
|
||||
bad_byte_helper(PROP_SHARED_SUB_AVAILABLE);
|
||||
}
|
||||
|
||||
/* ========================================================================
|
||||
* TEST SUITE SETUP
|
||||
* ======================================================================== */
|
||||
|
||||
int init_property_read_tests(void)
|
||||
{
|
||||
CU_pSuite test_suite = NULL;
|
||||
|
||||
test_suite = CU_add_suite("Property read", NULL, NULL);
|
||||
if(!test_suite){
|
||||
printf("Error adding CUnit Property read test suite.\n");
|
||||
return 1;
|
||||
}
|
||||
|
||||
if(0
|
||||
|| !CU_add_test(test_suite, "Truncated packet", TEST_truncated)
|
||||
|| !CU_add_test(test_suite, "Invalid property ID", TEST_invalid_property_id)
|
||||
|| !CU_add_test(test_suite, "No properties", TEST_no_properties)
|
||||
|| !CU_add_test(test_suite, "Single Payload Format Indicator", TEST_single_payload_format_indicator)
|
||||
|| !CU_add_test(test_suite, "Single Request Problem Information", TEST_single_request_problem_information)
|
||||
|| !CU_add_test(test_suite, "Single Request Response Information", TEST_single_request_response_information)
|
||||
|| !CU_add_test(test_suite, "Single Maximum QoS", TEST_single_maximum_qos)
|
||||
|| !CU_add_test(test_suite, "Single Retain Available", TEST_single_retain_available)
|
||||
|| !CU_add_test(test_suite, "Single Wildcard Subscription Available", TEST_single_wildcard_subscription_available)
|
||||
|| !CU_add_test(test_suite, "Single Subscription Identifier Available", TEST_single_subscription_identifier_available)
|
||||
|| !CU_add_test(test_suite, "Single Shared Subscription Available", TEST_single_shared_subscription_available)
|
||||
|| !CU_add_test(test_suite, "Duplicate Payload Format Indicator", TEST_duplicate_payload_format_indicator)
|
||||
|| !CU_add_test(test_suite, "Duplicate Request Problem Information", TEST_duplicate_request_problem_information)
|
||||
|| !CU_add_test(test_suite, "Duplicate Request Response Information", TEST_duplicate_request_response_information)
|
||||
|| !CU_add_test(test_suite, "Duplicate Maximum QoS", TEST_duplicate_maximum_qos)
|
||||
|| !CU_add_test(test_suite, "Duplicate Retain Available", TEST_duplicate_retain_available)
|
||||
|| !CU_add_test(test_suite, "Duplicate Wildcard Subscription Available", TEST_duplicate_wildcard_subscription_available)
|
||||
|| !CU_add_test(test_suite, "Duplicate Subscription Identifier Available", TEST_duplicate_subscription_identifier_available)
|
||||
|| !CU_add_test(test_suite, "Duplicate Shared Subscription Available", TEST_duplicate_shared_subscription_available)
|
||||
|| !CU_add_test(test_suite, "Bad Request Problem Information", TEST_bad_request_problem_information)
|
||||
|| !CU_add_test(test_suite, "Bad Request Response Information", TEST_bad_request_response_information)
|
||||
|| !CU_add_test(test_suite, "Bad Maximum QoS", TEST_bad_maximum_qos)
|
||||
|| !CU_add_test(test_suite, "Bad Retain Available", TEST_bad_retain_available)
|
||||
|| !CU_add_test(test_suite, "Bad Wildcard Subscription Available", TEST_bad_wildcard_sub_available)
|
||||
|| !CU_add_test(test_suite, "Bad Subscription Identifier Available", TEST_bad_subscription_id_available)
|
||||
|| !CU_add_test(test_suite, "Bad Shared Subscription Available", TEST_bad_shared_sub_available)
|
||||
){
|
||||
|
||||
printf("Error adding Property read CUnit tests.\n");
|
||||
return 1;
|
||||
}
|
||||
|
||||
return 0;
|
||||
}
|
||||
@ -0,0 +1,6 @@
|
||||
#include <logging_mosq.h>
|
||||
|
||||
int log__printf(struct mosquitto *mosq, int priority, const char *fmt, ...)
|
||||
{
|
||||
return 0;
|
||||
}
|
||||
Loading…
Reference in New Issue