Commit Graph

872 Commits (120bfb33b9792467ef278d6b7de53856ae482e46)

Author SHA1 Message Date
Roger A. Light 9f9813aff4 Fix Coverity Scan 1486949 Resource leak 4 years ago
Roger A. Light 15cd25c3e9 Fix Coverity Scan 1486949 Resource leak 4 years ago
Roger A. Light a4635682d1 Fix Coverity Scan 1486945 String not null terminated 4 years ago
Roger A. Light cac537830e Fix Coverity Scan 1486949 Resource leak 4 years ago
Roger A. Light 0549a6a9aa Fix Coverity Scan 1486957 Resource leak 4 years ago
Roger A. Light 1d805316ba Fix Coverity Scan 1486949 Resource leak 4 years ago
Roger A. Light fa0b532e69 Fix Coverity Scan 1486948 Structurally dead code 4 years ago
Roger A. Light a94eb99c97 Fix Coverity Scan 1486945 String not null terminated 4 years ago
Roger A. Light 1771dd9941 Fix Coverity Scan 1436854 Resource leak 4 years ago
Roger A. Light c985736866 Restrict persistence events to persisted clients only. 4 years ago
Roger A. Light 39f3030643 Fix client_generated flag not being copied on properties.
Closes #2401. Thanks to Diorcet Yann.
4 years ago
Roger A. Light 96931643a4 Use strings.h for strcasecmp, except on Windows.
Closes #2420. Thanks to Frédéric Fauberteau.
4 years ago
Roger A. Light 2afe19466a Remove unused macro. 4 years ago
Roger A. Light a0f58f20c3 Update threaded builds.
Most specifically use -pthread instead of -lpthread.
4 years ago
Roger A. Light ffb7661d86 Move shared code to common directory
This is currently limited to "utility" type functions and does not include code common to the library and broker that are protocol related.
4 years ago
Roger A. Light 5a3b42d4a4 Use path vars in Makefiles. 4 years ago
Roger A. Light bc1adfd46d CMake fixes.
Builtin websockets support.
Persist sqlite plugin build.
Broker cJSON support
Add wildcard-temp plugin.
4 years ago
Roger A. Light 6b32cf61b2 CMake build fixes, including sqlite support. 4 years ago
Roger A. Light 306215db39 Split library actions.c for easier discoverability. 4 years ago
Roger A. Light b5c77f264f Build fixes 4 years ago
Roger A. Light 4e731d2ac7 Fix lws based websockets connections. 4 years ago
Roger A. Light 75fa83976c Fix `seconds` part of mosquitto_time_ns() on Windows. 4 years ago
Roger A. Light 73f03983fb Socks proxy test plus fixes. 4 years ago
Roger A. Light fa9c2d0285 Fix incorrect header position. 4 years ago
Roger A. Light aa96c2d922 Check accept key with websockets clients. 4 years ago
Roger A. Light f5625f499f Client HTTP request size configurable. 4 years ago
Roger A. Light 0a0f4ead42 Plugin interface interface and test improvements. 4 years ago
Roger A. Light d546ba461a Test fixes. 4 years ago
Roger A. Light 500542351d Set pointers to NULL after freeing. 4 years ago
Roger A. Light 0f8733627a Plugin persistence interface. 4 years ago
Roger A. Light 2501a64035 Merge branch 'master' into develop 4 years ago
Roger A. Light eafa848180 Add client message stats to xtreport. 4 years ago
Roger A. Light affe6ece83 Add client msg int to allow easier ordering for plugins. 4 years ago
Roger A. Light 3b8a2e827e Fix compile flags. 4 years ago
Roger A. Light 94fcd470d0 Fix incorrect subscribe_callback in mosquittopp.h.
Closes #2367. Thanks to Jens Alfke.
4 years ago
Roger A. Light 11975332d4 Fix mosquitto_topic_matches_sub2() not using the length parameters.
Closes #2364. Thanks to Jens Alfke.
4 years ago
Roger A. Light f3590f3020 Don't pass NULL to printf %s.
This is undefined behaviour, and some platforms don't like it.

Issue #2355. Thanks to CJ Lee.
4 years ago
Roger Light 68504da4a6
Merge pull request #2372 from podsvirov/install-libmosquitto-archive
Set ARCHIVE DESTINATION for mosquitto library
4 years ago
Roger A. Light 65d20271a7 Better string 4 years ago
Konstantin Podsvirov b34817cfab Set ARCHIVE DESTINATION for mosquitto library
Signed-off-by: Konstantin Podsvirov <konstantin@podsvirov.pro>
4 years ago
Konstantin Podsvirov 6187143384 Set ARCHIVE DESTINATION for mosquittopp library
Signed-off-by: Konstantin Podsvirov <konstantin@podsvirov.pro>
4 years ago
Roger Light cd07f1136b Bump copyrights. 4 years ago
Roger A. Light 8ac11929cc Merge branch 'master' into develop 4 years ago
Roger Light 92f3db92d7 Windows build fixes. 4 years ago
Roger A. Light 7b614b3b59 Move to end of file on append, when on Windows. 4 years ago
Roger A. Light 91e8344a3e Windows build fixes. 4 years ago
Roger Light 51eda2bf79 Add more efficient keepalive check. 4 years ago
Roger A. Light 21ded3df0d Build fix 4 years ago
Roger A. Light 799cdead15 Experimental custom websockets support. 4 years ago
Roger A. Light be80a3f4d0 Fix client id not showing in log on failed connections, where possible. 4 years ago
Roger A. Light a1a190b482 Pointless whitespace tidy. 4 years ago
Roger A. Light 0ce167c472 Fix log file being truncated on Windows. 4 years ago
Roger Light 3f62e80300
Merge pull request #2317 from doragasu/fixes_discon_cb_on_tls_err
Call disconnect callback on TLS error.
4 years ago
Roger A. Light 0f2f77c945 Improve idle / mux timeout performance. 4 years ago
Roger Light 88dfac8e88 Windows threading support for the library. 4 years ago
Roger A. Light 9e28eea0a2 Initialise sockpairR/W to invalid in `mosquitto_reinitialise()`
This avoids closing invalid sockets in `mosquitto_destroy()` on error.

Closes #2326. Thanks to Arrigo Zanette.
4 years ago
Roger A. Light 330bf6efdc Various fixes around inflight quota management.
Closes #2306. Thanks to canique.
4 years ago
doragasu 4471ee9e47 Call disconnect callback on TLS error.
When using the library asynchronously, TLS errors caused e.g. because
of the date/time not set correctly, cause the connection to be silently
dropped without the disconnection callback being invoked, as described
in issue #1052.

This commit fixes the issue, returning the behavior to the one the
library had previous to version 1.5.4, if a TLS error occurs, the
disconnect callback will be invoked for the client to get notified of
the error.

Signed-off-by: doragasu <doragasu@protonmail.com>
4 years ago
Roger A. Light aa29b45e70 Merge branch 'master' into develop 4 years ago
Roger A. Light d09591d92e Fix reconnecting in some cases when using MOSQ_OPT_TLS_USE_OS_CERTS.
Fix reconnecting failing when MOSQ_OPT_TLS_USE_OS_CERTS was in use, but none
of capath, cafile, psk, nor MOSQ_OPT_SSL_CTX were set, and
MOSQ_OPT_SSL_CTX_WITH_DEFAULTS was set to the default value of true.

Closes #2288. Thanks to Poltorak Serguei.
4 years ago
Roger A. Light 605131502b Fix MOSQ_OPT_SSL_CTX not being able to be set to NULL.
Closes #2289. Thanks to Poltorak Serguei.
4 years ago
Roger A. Light 9d6a73f9f7 Fix CONNECT performance with many user-properties.
An MQTT v5 client connecting with a large number of user-property properties
could cause excessive CPU usage, leading to a loss of performance and
possible denial of service. This has been fixed.
4 years ago
Roger Light 32af599c81 Fix $share subscriptions not being recovered for durable clients.
If a plugin had granted ACL subscription access to a
durable/non-clean-session client, then removed that access, the client would
keep its existing subscription. This has been fixed.
4 years ago
Roger A. Light 376226c129 Build warning fixes. 4 years ago
Roger A. Light 9b25dd3b0d libressl build fixes.
Closes #2198. Thanks to Theo Buehler.
4 years ago
Roger A. Light 0d1837ebe3 Deconfigure thread mode when the loop thread ends.
Threaded mode is deconfigured when the mosquitto_loop_start() thread ends,
which allows mosquitto_loop_start() to be called again.

Closes #2242. Thanks to Timo Lange.
4 years ago
Roger A. Light 9526b4cf23 Check for file==dir only when reading. 4 years ago
Roger Light ba2ca33671 Strict protocol compliance fixes, and extensive test suite. 4 years ago
Roger Light 723b5d7081 Fix listener mount_point not being removed on outgoing messages.
Closes #2244. Thanks to alflexRH.
4 years ago
Roger Light 6608e852a1 Fix broker not quiting if `password_file` is specified as a directory.
Closes #2241. Thanks to Bryan Pearson.
4 years ago
Roger Light 93b2232bb9 Apply max_keepalive to MQTT v3.1.1 and v3.1 clients. 4 years ago
Roger A. Light ea371564e7 Disable TLS 1.3 when using TLS-PSK, because it isn't correctly config'd. 4 years ago
Roger A. Light a37c8e65d2 TLS-PSK mismatch fix.
Produce an error if a TLS-PSK client tries to connect to a broker
that is not configured with TLS-PSK.
4 years ago
Roger A. Light 79542158f4 Fix `max_connections` option not being correctly counted. 4 years ago
Roger A. Light 9a97a5afc4 Improve client protocol version number logging.
Protocol version numbers reported in the log when a client connects now
match the MQTT protocol version numbers, not internal Mosquitto values.
4 years ago
Roger A. Light 4e146b7b53 Fix possible out of bounds memory reads when reading configuration.
This would happen with a corrupt/crafted configuration file. Unless your
configuration file is writable by untrusted users this is not a risk.

Closes #567213. Thanks to Roland Sako.
4 years ago
Roger Light cad11de873
Merge pull request #2249 from cdelston0/develop-transitive-topics
Swap bridge topic storage from array to linked-list
4 years ago
Roger A. Light 49065f03a8 Merge remote-tracking branch 'origin/fixes' into develop 4 years ago
Chris Elston aa5233fc85 Swap bridge topic array to linked list
Bridge topics are added on startup to an allocated array which is
reallocated with each new topic.  This change alters bridge topic
storage to use a singly linked list.

This is to facilitate upcoming changes to support bridge topic
add/remove operations.
4 years ago
Roger A. Light a02aad0a9c Add mosquitto_sub_matches_acl_with_pattern. 4 years ago
Roger A. Light f90e55bd36 Reduce memory allocations when sending packets. 4 years ago
Roger A. Light e0309acebc Add mosquitto_sub_matches_acl()
This moves the sub matching sub code from the dynsec plugin to the library and broker, and removes all of the malloc calls at the same time.
4 years ago
Roger A. Light b3045d1adf Fix pattern matching with invalid prefix. 4 years ago
Roger A. Light 6502d6e5f4 Add mosquitto_topic_matches_sub_with_pattern()
And use it in the default security checks.
4 years ago
Roger A. Light dfd5dc5b92 Remove unused struct member. 4 years ago
Roger A. Light e0bcf8cda4 Simplify SSL accept/connect. 4 years ago
Roger A. Light 8416f928df Revert premature want_connect fix. 4 years ago
Roger A. Light 403691ce40 Add missing return types. 4 years ago
Roger A. Light 104b94db57 Fix non-reachable bridge blocking the broker on Windows.
Closes #2172. Thanks to Niclas Lindgren.
4 years ago
Roger A. Light 625e2a5060 Refactor to remove duplicate code. 4 years ago
Roger A. Light 906a515704 Simplify client message properties, only one is used. 4 years ago
Roger Light f934230251 Simplify out packet mutex use. 4 years ago
Roger A. Light 214feb8f6b Merge branch 'fixes' into develop 4 years ago
Roger A. Light 0d3870585b Plugin delayed authentication. 4 years ago
Roger A. Light 16fb0025a7 Improve QoS 0 outgoing packet queueing. 4 years ago
Roger Light 9bb58a88fc Cleanup messsage before return.
Coverity scan #1451483.
4 years ago
Roger Light 9c9ca33d63 Fix two potential leaks. 4 years ago
Roger Light 0a90e62f93 CMake tidy. 4 years ago
Roger Light 931c590a37
Merge pull request #2156 from abiliojr/improve_tls
add cipher settings for bridge, and support for TLS 1.3 ciphers
4 years ago
Roger A. Light a2ab20df13 Don't call read() if sockpairR < 0.
Coverity #1450782.
4 years ago