26f747e0ac
fix confusing log message on connack error
...
Signed-off-by: Abilio Marques <abiliojr@gmail.com>
4 years ago
94d61305fa
Fix bridge not respecting receive-maximum when reconnecting with MQTT v5.
4 years ago
9e5b850181
Check for NULL before strcmp.
4 years ago
5cae4d1d81
Fix broker sending duplicate CONNACK on failed MQTT v5 reauthentication.
...
Closes #2339 . Thanks to hvxl.
4 years ago
be80a3f4d0
Fix client id not showing in log on failed connections, where possible.
4 years ago
a1a190b482
Pointless whitespace tidy.
4 years ago
7061569bf4
Don't send retained messages when a shared subscription is made.
4 years ago
7b58eee414
Fix problem parsing config files with Windows line endings.
...
Closes #2297 . Thanks to all the people who commented there!
4 years ago
330bf6efdc
Various fixes around inflight quota management.
...
Closes #2306 . Thanks to canique.
4 years ago
7551a29985
Fix LWT messages not being delivered if `per_listener_settings` was set to true
...
Closes #2314 . Thanks to Marc Hamel.
4 years ago
d942ed7eec
Fix `max_keepalive` option not being able to be set to 0.
4 years ago
37b5aedcb6
Fix for #575314 .
...
Incoming QoS 2 messages that had not completed the QoS flow were not being
checked for ACL access when a clean session=False client was reconnecting.
Closes #575314 .
4 years ago
9d95cba95e
Fix leak.
4 years ago
32af599c81
Fix $share subscriptions not being recovered for durable clients.
...
If a plugin had granted ACL subscription access to a
durable/non-clean-session client, then removed that access, the client would
keep its existing subscription. This has been fixed.
4 years ago
376226c129
Build warning fixes.
4 years ago
9b25dd3b0d
libressl build fixes.
...
Closes #2198 . Thanks to Theo Buehler.
4 years ago
ba2ca33671
Strict protocol compliance fixes, and extensive test suite.
4 years ago
526b8430e2
Fix for #2283 .
...
Closes #2283 . Thanks to Heath Raftery.
4 years ago
93b2232bb9
Apply max_keepalive to MQTT v3.1.1 and v3.1 clients.
4 years ago
ea371564e7
Disable TLS 1.3 when using TLS-PSK, because it isn't correctly config'd.
4 years ago
0143db71a1
Fix TLS certs and PSK not being able to be config'd at the same time.
4 years ago
2ace833eee
Remove duplicate line
4 years ago
4e146b7b53
Fix possible out of bounds memory reads when reading configuration.
...
This would happen with a corrupt/crafted configuration file. Unless your
configuration file is writable by untrusted users this is not a risk.
Closes #567213 . Thanks to Roland Sako.
4 years ago
e3158e2b09
Merge pull request #2247 from Begasus/haiku
...
Haiku build fixes
4 years ago
0f49a9ff5b
Haiku build fixes
...
Signed-off-by: begasus <begasus@gmail.com>
4 years ago
99d7299b24
Fix qos0 messages not being queued when queue_qos0_message enabled.
...
Closes #2224 . Thanks to Luigi Caiffa.
4 years ago
42163634c7
Fix leak on crafted MQTT v5 CONNECT.
...
If a MQTT v5 client connects with a crafted CONNECT packet a memory leak
will occur.
Thanks to Kathrin Kleinhammer.
4 years ago
403691ce40
Add missing return types.
4 years ago
238b68686a
Fix bridge pollfd corruption on Windows.
...
Closes #2173 . Thanks to Niclas Lindgren.
4 years ago
104b94db57
Fix non-reachable bridge blocking the broker on Windows.
...
Closes #2172 . Thanks to Niclas Lindgren.
4 years ago
5851713f3e
Refactor to remove duplicate code.
4 years ago
0e1388a615
Fix the return of plugin__handle_message not being fully handled.
4 years ago
90e3b287de
Remove redundant check, this is handled in send__pubrec.
4 years ago
16fb0025a7
Improve QoS 0 outgoing packet queueing.
4 years ago
0db306ef6b
Fix compiler warning.
4 years ago
4a08626f43
Only a single call to lws_write() is required.
4 years ago
880df7360d
Fix bridge not reconnectng if the first reconnection attempt fails.
...
Closes #2207 . Thanks to Abilio Marques.
4 years ago
501690d312
Handle identifier==NULL case.
4 years ago
e1c8f09372
Remove C++ style comments.
4 years ago
5434931dbc
Merge branch 'fixes' of git://github.com/bk138/mosquitto into bk138-fixes
4 years ago
0446bba7df
Fix some conversion warnings.
5 years ago
fe10226cc9
Fix building with Visual Studio 2008
...
This older Microsoft compiler does not support mixing declarations and
code and misses some error defines. This commit enables building with
VS2008 by moving up some variable declarations and defining error
codes to their WinSock counterparts in case they're not defined.
Signed-off-by: Christian Beier <info@christianbeier.net>
5 years ago
702aaabee2
mux init must happen before bridges are started.
5 years ago
c418b57d0f
Fix possible crash having just upgraded from 1.6.
...
Happens if `per_listener_settings true` is set, and a SIGHUP is sent to
the broker before a client has reconnected to the broker.
Closes #2167 . Thanks to momoskitto.
5 years ago
983dc14f2c
Provide help for users trying to bind to privileged ports.
...
Closes #2098 .
5 years ago
6a4a547892
Fix segfault on client sending malformed CONNACk.
...
CVE-xxxx-xxxx: If an authenticated client connected with MQTT v5 sent a
malformed CONNACK message to the broker a NULL pointer dereference occurred,
most likely resulting in a segfault. This will be updated with the CVE
number when it is assigned.
Affects versions 2.0.0 to 2.0.9 inclusive.
Closes #2163 . Thanks to Bryan Pearson.
5 years ago
2de8c15bc9
Minor build fixes.
5 years ago
cca41d176d
Fix inconsistent sign in log__printf declaration.
5 years ago
9989a3502d
Add link to authentication options if running in local only mode.
5 years ago
a6bb8d3611
Don't over write new receive-maximum if a v5 client connects.
...
This is for when it takes over an old session.
Closes #2134 . Thanks to Frantisek Fuka.
5 years ago
Abilio Marques
Roger A. Light
begasus
Christian Beier