Commit Graph

78 Commits (4a6570567a25c9e187cdba40deb5dbe4a4b2cd91)

Author SHA1 Message Date
Roger A. Light 4d1b587e29 dynsec: Forbid deleting the anon group. 3 years ago
Roger A. Light df317ff71f Dynamic security: Fix the plugin being able to be loaded twice.
Currently only a single plugin can interact with a unique $CONTROL
topic. Using multiple instances of the plugin would produce duplicate
entries in the config file.

Closes #2601.
Closes #2470.
3 years ago
Roger A. Light 436f0b9348 dynsec: Fix modifyClient and modifyGroup commands
They will now not modify the client/group if a new group/client being
added is not valid, or on other failures.

Closes #2598. Thanks to Sebastian Szczepański.
3 years ago
Roger A. Light b22df5140e Clear errno before check. 3 years ago
Roger A. Light 80c7726d5c Fix confusing error message when dynamic security config file was a directory.
Closes #2520. Thanks to sezanzeb
3 years ago
Roger A. Light 96931643a4 Use strings.h for strcasecmp, except on Windows.
Closes #2420. Thanks to Frédéric Fauberteau.
4 years ago
Konstantin Podsvirov c4d51f0835 Fix DESTINATION for mosquitto_dynamic_security MODULE
On Windows MODULE will be installed as LIBRARY component
to `lib` folder that is not prefer for dynamic loaded modules
but can be found in RUNTIME DESTINATION (`bin` folder) too.

Signed-off-by: Konstantin Podsvirov <konstantin@podsvirov.pro>
4 years ago
Roger A. Light a1a190b482 Pointless whitespace tidy. 4 years ago
Roger Light c01ae67af7 Fix openssl not being linked to dynamic security plugin.
Closes #2277. Thanks to LeSuisse.
4 years ago
Roger Light e1c8f09372 Remove C++ style comments. 4 years ago
Martin Hauke e21eaeca37 CMake: Fix undefined symbols in plugins 5 years ago
Roger Light a5d9986cbd More compiler warning fixes. 5 years ago
Roger A. Light a4389fc9ce Fix SPDX identifiers: EDL-1.0 -> BSD-3-Clause.
The two licenses are the same.
5 years ago
Roger A. Light 5927778ae5 Improve logging in dynsec addGroupClient command.
Closes #2008. Thanks to Willem Eradus.
5 years ago
Roger Light c4f4fae5a0 dynsec: Improve logging in addGroupRole.
Close #2005. Thanks to Willem Eradus.
5 years ago
Roger A. Light 370cec5edd Fixes for lots of minor build warnings highlighted by Visual Studio. 5 years ago
Roger Light 7e1a818c54 Fix invalid behaviour in dynsec plugin.
This occurred if a group or client was deleted before a role that was
attached to the group or client is deleted.

Closes #1998. Thanks to Willem Eradus.
5 years ago
Roger A. Light 7fc472232c Merge branch 'fixes' 5 years ago
Roger A. Light b8962cc040 Add more log messages for dynsec load/save error conditions. 5 years ago
Roger A. Light c6a6165f3b Fix dynamic security configuration possibly not being reloaded on Windows only.
Closes #1962. Thanks to martgeier.
5 years ago
Peter Robinson 9d7580fdb6 Use libdir as the install prefix for plugins
Use the libdir variable from config.mk just like lib/ uses to ensure
that the plugins are installed into the same location as the library.
This fixes systems that use lib64 for libraries like most 64 bit
Linux distributions.

Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
5 years ago
Roger A. Light f7dc138157 Fix `install` target when using WITH_CJSON=no.
Closes #1938. Thanks to apple3306 and JulianCaruso.
5 years ago
Roger A. Light 3047374693 Drop hard coded linker flags. 5 years ago
Roger A. Light 791c63372b Fix cjson include paths. 5 years ago
Roger A. Light 26ffe1300a Various Windows build fixes. 5 years ago
Roger A. Light 550c54701e Fix cmake build when cjson not available. 5 years ago
Roger A. Light 42f09b8add Build fixes 5 years ago
Roger A. Light 3731535298 Add SPDX license identifiers. 5 years ago
Roger A. Light 0a7afd22c4 dynsec: Fix logging args. 5 years ago
Roger A. Light 692fa5537d dynsec: Reply with error on add role fail. 5 years ago
Roger A. Light 0605fd402a dynsec: Command logging. 5 years ago
Roger A. Light e5af6def25 dynsec: Simplify 5 years ago
Roger A. Light d0d36b7c33 dynsec: Remove unused code 5 years ago
Roger A. Light 31e3fa4d07 dynsec: Invalid UTF-8 tests, plus some fixes. 5 years ago
Roger A. Light c303c67461 dynsec: Return group not found on getGroup. 5 years ago
Roger A. Light 423e1a00d2 dynsec: Tests for group commands with invalid params, plus fixes. 5 years ago
Roger A. Light 6739152fda dynsec: Various minor fixes. 5 years ago
Roger A. Light 598b1d7b00 dynsec: Fix free on modifyClient. 5 years ago
Roger A. Light ba8e888e41 dynsec: Refactor some cJSON adding code to reduce redundancy 5 years ago
Roger A. Light d8775b7d9c dynsec: Consistent behaviour when setting clientid. 5 years ago
Roger A. Light c1489fc704 dynsec: Refactor duplicate group kick code. 5 years ago
Roger A. Light 7dc739a11e Disable dynsec build if cJSON or TLS not available. 5 years ago
Roger A. Light 782696c8e4 Simplify, remove duplication. 5 years ago
Roger A. Light c3daa247c2 dynsec: Cover setClientId in 14-dynsec-auth test. 5 years ago
Roger A. Light 584cf51ba7 Update to EPL-2.0 5 years ago
Roger A. Light 69f7fcae82 Support cJSON < 1.7.13. 5 years ago
Roger A. Light 5db971a0e9 dynsec: Client id is optional in setClientID. 5 years ago
Roger A. Light 0c6365726f Coverity Scan issues.
1436823
1436837
1436843
1432792
1436847
1436848
1436849
5 years ago
Roger A. Light f83fcc8535 Fix Coverity Scan issues.
1436866
1436865
1436864
1436862
1436857
1436856
1436852
1436851
5 years ago
Roger A. Light d1bf2c0d13 dynsec: Fix missing correlationData for getDefaultACLAccess. 5 years ago