4e3b8ed2b5
Fix cherry picked commit.
5 years ago
10ecae6275
Fix bridge sock not being removed from sock hash on error
...
Prior to this, duplicate entries could be added to the sock hash, which caused an infinite loop. Only affects bridges with bad settings on startup, and only when compiled using WITH_ADNS=yes.
Closes #1897 . Thanks to Rodolfo Ochoa.
5 years ago
18a6d79ab8
Fix cmake if condition in lib/CMakeLists.txt
...
Signed-off-by: Franz Auernigg <f.auernigg@commend.com>
5 years ago
b816d46508
Use db as a global var instead of passing to functions.
...
This allows a big swath of ifdefs to be removed. It also means savings as the db var is not passed around all of the time, and makes it easier to remove the final broker call to mosquitto_time() call in packet_mosq.c. In one test this reduced the calls to mosquitto_time() from 295k to 48k.
5 years ago
108b23ce6d
Reduce use of mosquitto_time() and time().
5 years ago
c2651cf005
Remove deprecation warning on libmosquittopp.
5 years ago
23d3c2641e
Optimise epoll event to context/listener mapping. Allows quicker lookups.
5 years ago
4d6384c758
Build and conversion fixes for build variants.
5 years ago
8e7e4a9d9a
Clients: Give warning if keepalive too low.
5 years ago
9c3a214a01
In android ndk doesn't exist librt and libpthread
...
Signed-off-by: Arenoros <arenoros@gmail.com>
5 years ago
add355a78b
QNX has no pselect() either.
...
Signed-off-by: raspopov <raspopov@cherubicsoft.com>
5 years ago
2e72d795a9
Fix timeout conversion error.
5 years ago
0097a85ce0
Something bad happened with a "timeout" parameter of mosquitto_loop() function in 4f61f6c161. Reverted.
...
Signed-off-by: raspopov <raspopov@cherubicsoft.com>
5 years ago
abbeb4494f
Change `tls_version` option behaviour.
...
The `tls_version` option now defines the *minimum* TLS protocol version to
be used, rather than the exact version.
Closes #1258 . Thanks to Daniele Sluijters.
5 years ago
88b5daee66
Try very hard not to produce "Socket error" message.
...
This happens when an unhandled error occurs on a socket/read write. The
message is confusing to people.
5 years ago
e82ee879d5
Merge branch 'fixes' into develop
5 years ago
53d63fe922
Fixed compilation error on Win32 UNICODE platform.
...
Signed-off-by: raspopov <raspopov@cherubicsoft.com>
5 years ago
6af56610ac
Fixed "config.h" file placement to help using it as a precompiled header.
...
Signed-off-by: raspopov <raspopov@cherubicsoft.com>
5 years ago
7ae7d73fd4
The loop in packet_write() means that `max_packets` isn't needed.
5 years ago
988b5cf0b2
Add missing header for QNX
...
<arpa/inet.h> header is required to compile this source. Without it, WARNING is generated.
mosquitto/lib/socks_mosq.c: In function 'socks5__send':
mosquitto/lib/socks_mosq.c:156:22: warning: implicit declaration of function 'inet_pton' [-Wimplicit-function-declaration]
ipv4_pton_result = inet_pton(AF_INET, mosq->host, &addr_ipv4);
Signed-off-by: ChangJoon Lee <changjoon.lee@lge.com>
5 years ago
4f61f6c161
Fix conversion errors.
5 years ago
6104172bcf
Fix connect properties not being sent.
...
This was happening when the client automatically reconnected.
Closes #1846 . Thanks to DSOFreak.
5 years ago
9724710cd6
Add MOSQ_OPT_BIND_ADDRESS.
...
This allows setting of a bind address independently of the
`mosquitto_connect*()` call.
5 years ago
89733138bb
CMake build fixes.
5 years ago
a65f946e83
Move headers to own directory.
5 years ago
c90e49af1b
Merge remote-tracking branch 'origin/fixes' into develop
5 years ago
2774515456
Fix missing mach/mach_time.h header on OS X.
...
Closes #1831 . Thanks to P-Hagen.
5 years ago
acf4ff3738
Fix stdin being closed by mistake
...
This was closing the sockpair* sockets before they were initialised to INVALID_SOCKET.
Close #1823 . Thanks to ostkamp.
5 years ago
a53712a14d
Don't use logging until log mutex is initialised.
...
Closes #1819 . Thanks to santoshks68.
5 years ago
298d84941e
Fix send quota being incorrecly reset on reconnect.
...
Closes #1822 . Thanks to Sarek.
5 years ago
56ba1b99db
Add `mosquitto_ssl_get()`.
...
This allow clients to access their SSL structure and
perform additional verification.
5 years ago
5daa5ee162
Add support for $CONTROL/ topics in plugins.
5 years ago
f0862e26ec
Add `mosquitto_kick_client_by_clientid()` and `mosquitto_kick_client_by_username()`
...
These can be used by plugins to disconnect clients.
5 years ago
bb5456729d
Move keepalive check code to separate file.
...
This is in preparation for changing to a tree based implementation.
5 years ago
3806296c15
Ld symbol of the mosquitto_property_copy_all has global bind now.
...
Signed-off-by: ignacy.ruksza <ignacy.ruksza@ledatel.pl>
5 years ago
39ff7226eb
Bump version, add new www posts.
5 years ago
79051fbdca
do not include pthread when compiling without threading support
...
This fixes the following error, when compiling for systems without
pthread support, and when passing WITH_THREADING=no to make:
thread_mosq.c:24:12: fatal error: pthread.h: No such file or directory
# include <pthread.h>
^~~~~~~~~~~
compilation terminated.
Signed-off-by: Titouan Christophe <titouan.christophe@railnova.eu>
5 years ago
2fdb5a0171
docs: move _string_option with rest of client options
...
It was grouped with the callbacks, where it didn't make a lot of sense.
Signed-off-by: Karl Palsson <karlp@tweak.net.au>
5 years ago
d254ea70df
docs: remove duplicate mosquitto_reconnect_delay_set
...
Was listed in both client options, and under the callbacks.
Signed-off-by: Karl Palsson <karlp@tweak.net.au>
5 years ago
c9218fd48c
Bump version.
5 years ago
b3c2ac20dc
Fix overly broad HAVE_PTHREAD_CANCEL compile guard.
...
Closes #1547 . Thanks to Markus Gothe.
5 years ago
4b100df5b1
Fix reconnect+will delay interval issue causing missing messages.
...
Fix clients not receiving messages after a previous client with the same client ID and positive will delay interval quit.
Closes #1752 . Thanks to Jiří Zuzaňák.
5 years ago
4ef48269f5
Fix mosquitto_loop_stop() not stopping on Windows
...
Closes #1748 . Closes #117 . Thanks to Sigmund Vik.
5 years ago
bd27935ff6
`mosquitto_loop_start()` now sets a thread name.
...
This applies on Linux, FreeBSD, NetBSD, and OpenBSD.
Closes #1777 . Thanks to ABuch19.
5 years ago
f180e923ef
Merge branch 'lazy_ssl' of git://github.com/abiliojr/mosquitto into abiliojr-lazy_ssl
5 years ago
9b5112f547
Fix unsigned compared against 0.
...
Coverity Scan 1431132.
5 years ago
1b060bb064
Guard against use-after-free.
...
Coverity Scan 1431131, 1431135, 1431141.
5 years ago
84e4ba2c1e
Send DISCONNECT with malformed-packet reason code on bad PUBLISHes.
5 years ago
d5aae3eca7
lazy init SSL
...
Signed-off-by: Abilio Marques <abiliojr@gmail.com>
5 years ago
d371b3c58b
Fix `mosquitto_publish*()` no longer returning `MOSQ_ERR_NO_CONN`.
...
This was always returning success when the client was not connected.
Closes #1725 . Thanks to BOTorioN.
5 years ago
d9003bb858
Don't use mutex until it is initialised.
...
Coverity Scan 1430456.
5 years ago
e3e8dc4ea4
Allow send__pub{ack,rec,rel,comp} to send properties.
5 years ago
c8964228e3
Improved documentation around connect callback return codes.
...
Close #1730 . Thanks to John Laird.
5 years ago
4ef7ea6244
extend ifdef guard to fix compilation on OpenBSD
...
otherwise in6_addr, AF_INET and AF_INET6 end up being undefined
Signed-off-by: Jasper Lievisse Adriaanse <jasper@humppa.nl>
5 years ago
a9c97efaa4
Document that keepalive must be >= 5 seconds.
5 years ago
cea0423e69
Update changelog and version.
5 years ago
8d54aaef89
add a refcount to library init/cleanup
...
Add a refcount around mosquitto_lib_init and mosquitto_lib_cleanup so
that multiple calls to init/cleanup don't trigger memory leaks or
double-frees.
Signed-off-by: Martin Kelly <mkelly@xevo.com>
5 years ago
d103174b5c
correct mosquitto.h return code documentation
...
We currently erroneously claim that mosquitto_lib_init cannot fail,
while it can fail on Windows, if WSAStartup fails in net__init. Correct
this.
Signed-off-by: Martin Kelly <mkelly@xevo.com>
5 years ago
61a50c60d2
add a refcount to library init/cleanup
...
Add a refcount around mosquitto_lib_init and mosquitto_lib_cleanup so
that multiple calls to init/cleanup don't trigger memory leaks or
double-frees.
Signed-off-by: Martin Kelly <mkelly@xevo.com>
5 years ago
762ad432e8
Fix support for openssl 3.0
5 years ago
21f203b91a
Don't treact unexpected PUBACK/COMP as fatal.
6 years ago
f0deb9a5a1
CMake: Make building clients, broker and C++ library optional.
...
Issue #1641 .
6 years ago
efb21fb09c
doc: lib clarify _topic_check functions
...
Removed some whitespace and copy paste errors.
Signed-off-by: Karl Palsson <karlp@etactica.com>
6 years ago
8c16d7cd50
doc: add mqtt5 property options.
...
This just gets them all listed, explaining the available apis where they
could be used is left as further work.
Signed-off-by: Karl Palsson <karlp@etactica.com>
6 years ago
1b4b6f4a2c
doc: lib: properly flag code samples for formatting
...
Uses the NaturalDocs 1.5 compatible style. (Forward compatible with v2)
Uses > for short snippets and the tagged style for longer snippets.
Signed-off-by: Karl Palsson <karlp@etactica.com>
6 years ago
fd83d2274f
doc: lib: avoid unintended code formatting
...
Signed-off-by: Karl Palsson <karlp@etactica.com>
6 years ago
1331399228
doc: lib: specifically document mqtt5_sub_options
...
This makes the documentation of the options available in
https://mosquitto.org/api/files/mosquitto-h.html#mosquitto_subscribe_v5
a lot cleaner. (and also _subscribe_multiple())
Signed-off-by: Karl Palsson <karlp@etactica.com>
6 years ago
d46707fe02
doc: lib_vesion: correctly format return values
...
Signed-off-by: Karl Palsson <karlp@etactica.com>
6 years ago
765f7343c2
doc: lib: _xxx_option() and opts_set() cleanup list syntax
...
This change improves the option list rendering by correctly triggering
naturaldocs detection of the lists. No change other than line breaks
and whitespace.
Signed-off-by: Karl Palsson <karlp@etactica.com>
6 years ago
6c7ef15112
doc: lib: group all _option functions together.
...
_string_option was grouped with the callbacks instead of _int_option and
_void_option. Grouped them all together neatly.
Signed-off-by: Karl Palsson <karlp@etactica.com>
6 years ago
a16d7e0661
iDon't treat an unexpected PUBREL as fatal.
...
Issue #1629 . Thanks to radcrabs.
6 years ago
346f695937
Separate out delay code from previous commit.
...
Plus add missing header.
6 years ago
5cf94d2e57
Merge branch 'fixes' of git://github.com/ChristianS99/mosquitto into fixes
6 years ago
7f41e37f0f
Fix use of sed on BSD.
...
Closes #1614 . Thanks to Christoph Krey.
6 years ago
c84d175b3d
Fixes for the poor souls stuck on <c99.
...
Closes #1622 .
6 years ago
d96543c0b8
Merge branch 'fixes' into develop
6 years ago
b544b46156
Update version.
6 years ago
b0a065f790
Update changelog. Release page. Bump copyright.
6 years ago
b6a54a21d8
Remove duplicate code.
6 years ago
8d5fd7d1e2
Fix `mosquitto_topic_matches_sub()` behaviour with wildcards in topic.
...
It was not returning MOSQ_ERR_INVAL if the topic contains a wildcard.
Closes #1589 . Thanks to mdelete.
6 years ago
2a8c1d03f5
Merge branch 'coverity-fixes' into fixes
6 years ago
7a5c2d4da5
Bugfix: include "deps" directory only if BUNDLED_DEPS has been provided and set to true
...
Signed-off-by: Gianfranco Costamagna <costamagnagianfranco@yahoo.it>
6 years ago
3a89059271
Don't call SSL_shutdown() if SSL init hasn't completed.
6 years ago
07c54627e9
Print OpenSSL errors in more situations
...
Covers when loading certificates fails, or there are ENGINE problems.
Closes #1552 . Thanks to Michael Richardson.
6 years ago
27b4518d7e
Improve password file parsing in the broker and mosqitto_passwd.
...
Closes #1584 . Thanks to panava.
6 years ago
e188a6b500
More whitespace trimming fixes/consolidation.
6 years ago
70fd600c3a
Fix trailing whitespace not being trimmed on acl users.
...
Closes #1539 . Thanks to CliveJL and LeonPoon.
6 years ago
81641df043
Expose net__print_ssl_error() prototype.
6 years ago
11ece604c4
Merge branch 'bugfix-MemLeak_in_handle_unsubscribe' of git://github.com/panava/mosquitto into panava-bugfix-MemLeak_in_handle_unsubscribe
6 years ago
89b55094c0
Merge branch 'bugfix-NullDeref_in_util_mosc.c' of git://github.com/panava/mosquitto into panava-bugfix-NullDeref_in_util_mosc.c
6 years ago
50735afb5b
Fix for internal logging not printing.
6 years ago
dd6d8237cb
Potential Null pointer dereference in util_mosq.c
...
Reason: There is no check that the mosquitto__malloc at line 162 was sucessfull.
This could result to a Null pointer dereference in the memcpy call at line 166.
Fix: I added the check.
Signed-off-by: Panagiotis Vasilikos <panagiotis.vasilikos@alexandra.dk>
6 years ago
8f1c8cba59
Set minimum keepalive argument to `mosquitto_connect*()` to be 5 seconds.
...
Closes #1550 . Thanks to Markus Gothe.
6 years ago
caeb211cc5
Memory leak in socks_mosq.c
...
Reason: The memory allocated for the packet pointer at line 155 is not freed
before returning at line 188.
Fix: I inserted the mosquitto__free(packet) statement just before returning
at line 188.
Signed-off-by: Panagiotis Vasilikos <panagiotis.vasilikos@alexandra.dk>
6 years ago
4408339dbc
Make consts unsigned where they are compared against unsigned.
6 years ago
05ec02b3f3
Remove dead values.
6 years ago
d60e86d2a3
Add TCP_NODELAY support to lib and clients.
...
Closes #1526 . Thanks to Felix Moessbauer.
6 years ago
a3ebeff9d7
fix: replace sleep with (p)select in loop_forever
...
sleep was blocking loop_stop(force=false) since it
was uniteruptible
Signed-off-by: Christian Schneider <cschneider@radiodata.biz>
6 years ago
c0443637e8
Merge branch 'master'
...
Conflicts:
ChangeLog.txt
config.mk
src/context.c
src/loop.c
src/subs.c
test/broker/01-connect-bad-packet.py
test/broker/02-subpub-qos1-bad-pubcomp.py
test/broker/02-subpub-qos1-bad-pubrec.py
test/broker/02-subpub-qos2-bad-puback-1.py
test/broker/02-subpub-qos2-bad-puback-2.py
test/broker/02-subpub-qos2-bad-pubcomp.py
test/broker/02-subpub-qos2.py
test/broker/07-will-null-topic.py
6 years ago
b410568299
Bump version, add release post.
6 years ago
Roger A. Light
Franz Auernigg
Arenoros
raspopov
CJ Lee
ignacy.ruksza
Titouan Christophe
Karl Palsson
Abilio Marques
Jasper Lievisse Adriaanse
Martin Kelly
Karl Palsson
Gianfranco Costamagna
Panagiotis Vasilikos
Christian Schneider