9751cccf0d
Windows: Fix possible crash when client disconnects.
...
Closes #1137 . Thanks to Kris Mattheus.
7 years ago
0beeee189e
Fix Will not being sent for Websockets clients.
...
Closes #1143 . Thanks to salcedo.
7 years ago
5df00f66b4
Fix spaces not being allowed in the bridge remote_username option.
...
Closes #1131 . Thanks to beville.
7 years ago
cbd5306aec
Fix and tests for CVE-2018-12546.
7 years ago
5820b9e4e7
Fix and tests for security bug #541870 .
7 years ago
3559b66ade
Fix and tests for security bug #543401 .
7 years ago
cecf8f838f
Include sys/socket.h for AF_INET definition
...
Without this, mosquitto doesn't build on FreeBSD with websockets enabled
Signed-off-by: Steven Lawrance <stl@koffein.net>
7 years ago
9dd8d1e054
Handle mismatched handshakes properly.
...
For example, a QoS1 PUBLISH with QoS2 reply.
7 years ago
80d77983d3
ignore inline comments while parsing optional config params
...
Signed-off-by: Vinod Kumar <kumar003vinod@gmail.com>
7 years ago
e7e69eadb7
Fix compilation when openssl deprecated APIs are not available.
...
Closes #1094 . Thanks to Rosen Penev.
7 years ago
8fce26134b
Fix comparison of boolean values in CMake build.
...
Closes #1101 . Thanks to Mojca Miklavec and Andrew L. Moore.
7 years ago
89f3d7bb3f
Don't print connect/disconnect messages when connection_messages false.
...
Closes #772 . Closes #613 . Closes #537 .
Thanks to Christopher Maynard, Brandon Arrendondo, and qubeck.
7 years ago
a00dd29af8
Fix building where TLS-PSK is not available.
...
Closes #68 .
7 years ago
9097577b49
Fix acl_file being ignore for default listener if with per_listener_settings
...
Close #1073 . Thanks to Jef Driesen.
Bug: https://github.com/eclipse/mosquitto/issues/1073
7 years ago
1a6f8d3c28
src: ASN1_STRING_data is deprecated in OpenSSL 1.1
...
ASN1_STRING_get0_data replaces ASN1_STRING_data in OpenSSL 1.1 therefore
add an #ifdef for backwards compatibility.
Signed-off-by: Jelle van der Waa <jelle@vdwaa.nl>
7 years ago
ead440e47d
bridge: fix issue where keepalive_interval gets added to restart_timeout using ADNS
...
Signed-off-by: Abilio Marques <abiliojr@gmail.com>
7 years ago
3a871828ac
Print message on error when installing as a Windows service.
7 years ago
c9ed2708f6
Don't reload auth_opt_ options on reload.
...
This matches the behaviour of the other plugin options.
Closes #1068 . Thanks to Jason McFadyen.
Bug: https://github.com/eclipse/mosquitto/issues/1068
7 years ago
464b12f3d6
Fix outgoing retained messages not being sent by bridges.
...
This now happens on initial connection, after CONNACK is processed,
before it was happening (and being dropped) before the connection was
made.
Closes #1040 . Thanks to giover.
Bug: https://github.com/eclipse/mosquitto/issues/1040
7 years ago
e169f1c7c2
When using ADNS, don't ask for all network protocols when connecting.
...
This can lead to confusing "Protocol not supported" errors if the
network is down, because UDP sockets are provided.
Thanks to jsaak.
Closes #1062 .
Bug: https://github.com/eclipse/mosquitto/issues/1062
7 years ago
d29dac087d
Add socket_domain option.
7 years ago
9464e3fe19
Guard against possible null client id.
7 years ago
b54e379fba
Fix websockets listeners not verifying client certs.
...
When using a TLS enabled websockets listener with "require_certificate"
enabled, the mosquitto broker does not correctly verify client certificates.
This is now fixed. All other security measures operate as expected, and in
particular non-websockets listeners are not affected by this. Closes #996 .
Thanks to creising.
7 years ago
ba67e1ffe5
Don't use gnu-specific strerror_r.
7 years ago
34c752a0d0
Give better error message if a client sends a password without a username.
...
Closes #1015 . Thanks to TabascoEye.
7 years ago
9f7577aab6
$SYS/broker/clients/disconnected should never be negative.
...
Closes #287 . Thanks to Lovisa Johansson.
Bug: https://github.com/eclipse/mosquitto/issues/287
7 years ago
d7bcec4878
Don't disconnect clients when a plugin denies SUBSCRIBE.
...
Thanks to Ibrahim Koujar.
Bug: https://github.com/eclipse/mosquitto/issues/1016
7 years ago
a4a5236568
fix bug where bridge doesn't honor restart_timeout setting
...
Signed-off-by: Abilio Marques <abiliojr@gmail.com>
7 years ago
e86b27a2da
Adding support for QNX7.0.0
...
Change-Id: Id01e2880aa5cadc0e93a46b95fe675e1938051fa
Signed-off-by: Bartosz Taczała <bartosz.taczala@mobica.com>
7 years ago
eff8fab1b4
Only process network errors for clients that have nothing to read.
...
Closes #7 .
7 years ago
93f9e965a8
Only remove context from hash if there is a client id.
...
This should never happen, but just in case.
7 years ago
35dea07dcd
Merge branch 'master'
7 years ago
e492a61cd8
return MOSQ_ERR_INVAL if config has invalid boolean value
...
Signed-off-by: Vinod Kumar <kumar003vinod@gmail.com>
7 years ago
588d39efdc
Fix Windows version not starting if include_dir did not contain any files.
...
Closes #566 .
Thanks to marleau.
7 years ago
f9c9f3d396
Fix incorrect hash usage with duplicate clients.
...
Fix duplicate clients being added to by_id hash before the old client
was removed.
Closes #645 .
7 years ago
7b1892caef
Fix retained msgs not sent by bridges.
...
This occurred when a bridge connected for the first time and so made a
local subscription for outgoing topics.
Closes #701 .
7 years ago
f7474d3482
Revert "Remove some test that was always true"
...
This reverts commit 6fc7cadb63
7 years ago
e3b4bd8937
fix signal handler on win32
...
The signal handler thread on win32 did listen to 4 HANDLEs,
of which only 3 were initialized.
The result was 1 thread eating 100% cpu.
This commit reduces the HANDLE array storage.
Signed-off-by: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
7 years ago
7ca3a24686
Remove requirement to use `user root` in snap package config files.
7 years ago
0e16a248f2
Elevate log level to warning for situation when socket limit is hit.
7 years ago
55ca61f14e
Fix segfault on HUP when bridges and security options are configured.
...
Closes #849 . Closes #965 . Thanks to Wolfgand Hottgenroth and Dustin Sallings.
7 years ago
2b4ba10b3d
Fix "round_robin false" behaviour.
...
Closes #481 .
7 years ago
3ae387e232
Close spare sock at exit.
7 years ago
1e47ee4cad
Fix for bridge connections when using WITH_ADNS=yes.
7 years ago
d1b36507db
Better implementation of #948 .
7 years ago
ee8e20de75
Fix excessive CPU usage when the number of sockets exceeds the system limit.
...
Closes #948 . Thanks to wiebeytec.
7 years ago
dceb02f444
Make it easier to build without bundled uthash.h.
...
Use "make WITH_BUNDLED_DEPS=no".
7 years ago
e6a0199bb2
Fix incorrect call to setsockopt() for TCP_NODELAY.
...
Closes #941 . Thanks to rfalke.
Signed-off-by: Roger A. Light <roger@atchoo.org>
7 years ago
2221deb7a7
Fix build when using WITH_ADNS=yes.
7 years ago
11395f9852
Fix accessor functions for username and client id when used in plugin auth check.
7 years ago
Roger A. Light
Steven Lawrance
Vinod Kumar
Jelle van der Waa
Abilio Marques
Bartosz Taczała
Kurt Van Dijck