Commit Graph

1210 Commits (b4c86df6f581f5913917ba792d4760f94e8625d1)

Author SHA1 Message Date
Roger Light e1c8f09372 Remove C++ style comments. 5 years ago
Roger Light 5434931dbc Merge branch 'fixes' of git://github.com/bk138/mosquitto into bk138-fixes 5 years ago
Roger A. Light 0446bba7df Fix some conversion warnings. 5 years ago
Christian Beier fe10226cc9 Fix building with Visual Studio 2008
This older Microsoft compiler does not support mixing declarations and
code and misses some error defines. This commit enables building with
VS2008 by moving up some variable declarations and defining error
codes to their WinSock counterparts in case they're not defined.

Signed-off-by: Christian Beier <info@christianbeier.net>
5 years ago
Roger Light 702aaabee2 mux init must happen before bridges are started. 5 years ago
Roger Light c418b57d0f Fix possible crash having just upgraded from 1.6.
Happens if `per_listener_settings true` is set, and a SIGHUP is sent to
the broker before a client has reconnected to the broker.

Closes #2167. Thanks to momoskitto.
5 years ago
Roger A. Light 983dc14f2c Provide help for users trying to bind to privileged ports.
Closes #2098.
5 years ago
Roger A. Light 6a4a547892 Fix segfault on client sending malformed CONNACk.
CVE-xxxx-xxxx: If an authenticated client connected with MQTT v5 sent a
malformed CONNACK message to the broker a NULL pointer dereference occurred,
most likely resulting in a segfault. This will be updated with the CVE
number when it is assigned.
Affects versions 2.0.0 to 2.0.9 inclusive.

Closes #2163. Thanks to Bryan Pearson.
5 years ago
Roger Light 2de8c15bc9 Minor build fixes. 5 years ago
Roger Light cca41d176d Fix inconsistent sign in log__printf declaration. 5 years ago
Roger Light 9989a3502d Add link to authentication options if running in local only mode. 5 years ago
Roger Light a6bb8d3611 Don't over write new receive-maximum if a v5 client connects.
This is for when it takes over an old session.

Closes #2134. Thanks to Frantisek Fuka.
5 years ago
Roger A. Light 891be8c2fe Fix `max_keepalive` option not applying to keepalive=0.
Closes #2117. Thanks to David Nadlinger.
5 years ago
Roger A. Light 720ce01faf Minor tweaks to PR. 5 years ago
Roger A. Light 87cf3680e5 Merge branch 'master' of git://github.com/vidarino/mosquitto into vidarino-master 5 years ago
Roger A. Light f4d088b6d0 Improve logging of pull request.
Improve handling of invalid combinations of listener address and bind
interface configurations. Closes #2081.
5 years ago
Roger A. Light 095d6e1caa Merge branch 'mosterdt-fix_interface_binding' into fixes 5 years ago
Roger A. Light 88d2c74ab2 Fix bridge backoff calculation. 5 years ago
Roger A. Light 4b0a4c5c08 Merge branch 'fix-backoff' of git://github.com/abiliojr/mosquitto into abiliojr-fix-backoff 5 years ago
Roger A. Light 8a5de787a7 Merge branch 'fix_interface_binding' of git://github.com/mosterdt/mosquitto into mosterdt-fix_interface_binding 5 years ago
Roger A. Light b7a08d5c40 Fix TLS bridge/lib incorrectly connecting on invalid CA file.
Closes #2130. Thanks to becz.
5 years ago
Roger Light ace2aa764e Fix cmake epoll detection. 5 years ago
Roger A. Light e401def06d Fix QoS 0 messages not being delivered when max_queued_bytes was configured.
Closes #2123. Thanks to quackgizmo.
5 years ago
Roger A. Light f89a3c3fc0 Fix messages to `$` prefixed topics being rejected.
Closes #2111. Thanks to yellowgg2.
5 years ago
Roger Light 64f697d55d Fix `tls_version` behaviour not matching documentation.
It was setting the exact TLS version to use, not the minimium TLS
version to use.

Closes #2110. Thanks to Petter Jönsson.
5 years ago
Abilio Marques 2a38b7115b brige: fix backoff not working for remote broker returned errors
Signed-off-by: Abilio Marques <abiliojr@gmail.com>
5 years ago
Vidar Madsen ebfcc84cda Add new function to header. Minor tweaks.
Signed-off-by: Vidar Madsen <vidarino@gmail.com>
5 years ago
Vidar Madsen 6bea9f7b32 Handle stale stored messages with conflicting message IDs.
Signed-off-by: Vidar Madsen <vidarino@gmail.com>
5 years ago
Roger A. Light 1b24f625ea Give compile time warning for libwebsockets
If it is compiled without external poll support.

Closes #2060. Thanks to Yannic Schröder.
5 years ago
Thomas De Backer fd2f764d36 Check host address binding before overwriting
Signed-off-by: Thomas De Backer <mosterdt@debacker.me>
5 years ago
Thomas De Backer 764aa4e8dc Correct interface binding
Signed-off-by: Thomas De Backer <mosterdt@debacker.me>
5 years ago
Roger A. Light 4a738f154e Fix openssl engine not being able to load private key.
Closes #2066. Thanks to Boris Vanhoof.
5 years ago
Roger A. Light 7a3b69f2d7 Fix possible leak during connect.
Closes #2057. Thanks to Przemysław Zygmunt.
5 years ago
Roger A. Light 1e6be1f123 Fix some minor memory leaks on exit only. 5 years ago
Roger A. Light 2749b8c5b8 Merge branch 'fixes' 5 years ago
Roger A. Light 6e3738dcf0 Fix bridges not always connecting on Windows.
Closes #2043. Thanks to ttsorensen.
5 years ago
Roger A. Light 706a1f3f29 Fix more minor compiler warnings. 5 years ago
Roger A. Light cda84950bb Fix mux_epoll__handle() use. 5 years ago
Roger A. Light a4389fc9ce Fix SPDX identifiers: EDL-1.0 -> BSD-3-Clause.
The two licenses are the same.
5 years ago
Roger A. Light cf1098eff1 Send protocol error on topic alias not found.
The error topic-alias-invalid was being sent if an MQTT v5 client published
a message with empty topic and topic alias set, but the topic alias hadn't
already been configured on the broker. This has been fixed to send a
protocol error, as per section 3.3.4 of the specification.
5 years ago
Roger A. Light 3c58ac9308 Fix `message_size_limit` not applying to the Will payload.
Closes #2022. Thanks to Umberto Morelli.
5 years ago
Roger A. Light 4165224885 Fix reloading of listeners where multiple listeners have the same port.
This is only possible where they have different bind addresses.

Closes #2029. Thanks to Simon Aldrich.
5 years ago
Roger A. Light e2ebddfc54 Improve logging in obscure cases when a client disconnects.
Closes #2017. Thanks to Craig Leres.
5 years ago
Roger A. Light 00083623f0 Fix websockets listeners with TLS not responding.
Closes #2020. Thanks to FozzTexx.
5 years ago
Roger A. Light b8c6f26995 Fix message expiry interval property not being honoured for plugins.
This happened in `mosquitto_broker_publish` and
`mosquitto_broker_publish_copy` only.
5 years ago
Roger A. Light 4be32aefc6 Fix potential duplicate Will messages being sent.
This could have occurred when a will delay interval had been set.
5 years ago
Roger A. Light 695bbc33c8 Fix calculation of remaining length parameter for websockets clients.
Only affects those clients that send fragmented packets.

Closes #1974. Thanks to 贺亚东.
5 years ago
Roger A. Light 09a870c342 Better behaved lws external poll code. 5 years ago
Roger Light 4a114c6151 Remove unused struct member. 5 years ago
Roger A. Light 370cec5edd Fixes for lots of minor build warnings highlighted by Visual Studio. 5 years ago