8416f928df
Revert premature want_connect fix.
4 years ago
403691ce40
Add missing return types.
4 years ago
104b94db57
Fix non-reachable bridge blocking the broker on Windows.
...
Closes #2172 . Thanks to Niclas Lindgren.
4 years ago
625e2a5060
Refactor to remove duplicate code.
4 years ago
16fb0025a7
Improve QoS 0 outgoing packet queueing.
4 years ago
9bb58a88fc
Cleanup messsage before return.
...
Coverity scan #1451483 .
4 years ago
a2ab20df13
Don't call read() if sockpairR < 0.
...
Coverity #1450782 .
4 years ago
b4c86df6f5
Fix missing control path.
...
Closes #2190 . Thanks to RengeRenge.
4 years ago
e1c8f09372
Remove C++ style comments.
4 years ago
fe10226cc9
Fix building with Visual Studio 2008
...
This older Microsoft compiler does not support mixing declarations and
code and misses some error defines. This commit enables building with
VS2008 by moving up some variable declarations and defining error
codes to their WinSock counterparts in case they're not defined.
Signed-off-by: Christian Beier <info@christianbeier.net>
5 years ago
6ebbb4d654
Fix possible socket leak.
...
This would occur if a client was using `mosquitto_loop_start()`, then if
the connection failed due to the remote server being inaccessible they
called `mosquitto_loop_stop(, true)` and recreated the mosquitto object.
See: https://www.eclipse.org/forums/index.php?t=rview&goto=1839865#msg_1839865
5 years ago
0f9e5795a2
Merge pull request #2145 from abiliojr/empty_sockpairR
...
Fully empty sockpairR on interruptible_sleep
5 years ago
dd4a64b049
fully empty socketpairR on interruptible_sleep
...
Signed-off-by: Abilio Marques <abiliojr@gmail.com>
5 years ago
91f34e084f
fix duplication of messages during connect
...
Signed-off-by: Abilio Marques <abiliojr@gmail.com>
5 years ago
2de8c15bc9
Minor build fixes.
5 years ago
cca41d176d
Fix inconsistent sign in log__printf declaration.
5 years ago
f8838243fb
Fix connections retrying very rapidly in some situations.
...
Thanks to Abilio Marques.
5 years ago
b7a08d5c40
Fix TLS bridge/lib incorrectly connecting on invalid CA file.
...
Closes #2130 . Thanks to becz.
5 years ago
e401def06d
Fix QoS 0 messages not being delivered when max_queued_bytes was configured.
...
Closes #2123 . Thanks to quackgizmo.
5 years ago
2190e98b20
Fix memory tracking not being available on FreeBSD or macOS.
...
Closes #2096 . Thanks to blusewang.
5 years ago
9b08faf0bd
Fix mosquitto_{pub|sub}_topic_check() function returns.
...
The would not return MOSQ_ERR_INVAL on topic == NULL.
5 years ago
e98cc28cd3
Move check after current_out_packet is updated.
5 years ago
18bad1ff32
Unconditionally adding an event to the epoll causes 100% CPU usage. This happens when the connection to the server is established and the client has not sent any data yet.
...
Signed-off-by: Przemek Zygmunt <p.zygmunt@acsoftware.pl>
5 years ago
6e3738dcf0
Fix bridges not always connecting on Windows.
...
Closes #2043 . Thanks to ttsorensen.
5 years ago
706a1f3f29
Fix more minor compiler warnings.
5 years ago
a4389fc9ce
Fix SPDX identifiers: EDL-1.0 -> BSD-3-Clause.
...
The two licenses are the same.
5 years ago
370cec5edd
Fixes for lots of minor build warnings highlighted by Visual Studio.
5 years ago
fabdfcc060
Further fix for large packets not being sent in a timely fashion.
5 years ago
c604cf8fd0
net__write buf should be const.
5 years ago
b2da540c64
Fix large packets not being completely published to slow clients.
...
Also fix bridge connection not relinquishing POLLOUT after messages are
sent.
Closes #1977 . Thanks to marchaesen.
Closes #1979 . Thanks to GorazdKikelj.
5 years ago
2db9aecac4
Do not reset bind address option if passed NULL.
...
mosquitto_connect_bind_async() and mosquitto_connect_bind_v5() should not
reset the bind address option if called with bind_address == NULL.
Otherwise calling mosquitto_connect_async() will *force* the bind
address to be reset, even if previously set with
mosquitto_string_option().
5 years ago
e02b5a2775
Fix $SYS/broker/publish/messages/+ counters not being updated for QoS 1, 2
...
Closes #1968 . Thanks to promahn.
5 years ago
757902bcf8
Improve struct packing.
5 years ago
d8dcfd75fe
lib: Fix DH group not being set for TLS connections.
...
This meant ciphers using DHE couldn't be used.
Closes #1925 . Closes #1476 . Thanks to Jonathan Sönnerup, Valerii
Demeshko, and sectokia.
5 years ago
71845d28ac
Fixed some VS2017 compilation error and warnings ( #1916 )
...
* Fixed some VS2017 compilation errors and warnings.
Signed-off-by: raspopov <raspopov@cherubicsoft.com>
5 years ago
828e7ae130
More conversion fixes.
5 years ago
df1802d8f1
Fix client state conversion warnings.
5 years ago
232a759320
Log client port on new connections.
...
Closes #1911 . Thanks to twegener-embertec.
5 years ago
3731535298
Add SPDX license identifiers.
5 years ago
04c110183c
Bridge support for MQTT v5 maximum-qos.
5 years ago
e030ca45cd
Fix connack error printing.
5 years ago
0c22f475ff
Fix bridges incorrectly setting Wills to manage remote notifications.
...
This is for when `notifications_local_only` was set true.
Closes #1902 . Thanks to marcinkowskip.
5 years ago
b34dcd2a67
Final remove support for legacy libwebsockets
...
This means libwebsockets < 2.4.0.
5 years ago
29c771cdd4
Add lib and client support for OS CA certs
...
- Add `MOSQ_OPT_TLS_USE_OS_CERTS` option, to instruct the client to load and trust OS provided CA certificates for use with TLS connections.
- All clients now load OS provided CA certificates if used with `-L
mqtts://...`, or if port is set to 8883 and no other CA certificates are
used. Closes #1824 .
- Add the `--tls-use-os-certs` option to all clients.
Closes #1824 . Thanks to Jens Reimann.
5 years ago
a3258f7d82
Packet cleanup without locks
...
Prevents use of invalid mutexes during mosquitto_destroy.
Closes #1914 . Thanks to Nikolay Raspopov.
5 years ago
584cf51ba7
Update to EPL-2.0
5 years ago
dac841a342
Better outgoing QoS 0 limiting.
5 years ago
2755fe3c4c
Apply limits to QoS 0 outgoing messages.
5 years ago
4da1f15b41
Fix Coverity Scan errors.
...
1436854
1436844
5 years ago
d26534e22b
Fix Coverity scan issues.
...
1302840
1353078
1431131
1431134
1431135
1436826
1436827
1436828
1436830
1436831
1436834
1436835
1436838
1436839
1436840
1436844
1436846
1436853
1436854
1436859
1436860
1436861
1436863
1436867
5 years ago
Roger A. Light
Christian Beier
Abilio Marques
Przemek Zygmunt
Nikolay Raspopov