Commit Graph

326 Commits (d8cc5bc4fe7efecb4374e25a96d31cabff390da7)

Author SHA1 Message Date
Roger A. Light 2c54104ce3 [191] Fix some $SYS messages being incorrectly persisted.
Closes #191.

Bug: https://github.com/eclipse/mosquitto/issues/191
9 years ago
Roger A. Light 23113bb5f5 [7] Don't disconnect client on HUP before reading the pending data.
Closes #7.

Bug: https://github.com/eclipse/mosquitto/issues/7
9 years ago
Roger A. Light 8663d6aff7 Merge branch 'master' of github.com:eclipse/mosquitto 9 years ago
Roger A. Light 1cd40925b8 [184] Don't attempt to install docs when WITH_DOCS=no.
Thanks to minghuadev.

Bug: https://github.com/eclipse/mosquitto/issues/184
9 years ago
Roger A. Light 63416e6547 ; 9 years ago
Roger A. Light 5d96c3d7ba [186] Fix TLS operation with websockets listeners and libwebsockts 2.x.
Bug: https://github.com/eclipse/mosquitto/issues/186
9 years ago
Roger A. Light ea2baa876c Fix rare possible crash when writing persistence file. 9 years ago
Roger A. Light ff78cd7873 Fix publishing of $SYS/broker/clients/maximum. 9 years ago
Roger A. Light 6f5f445196 [169] mosquitto_passwd handles unknown cmd args properly.
Closes #169. Thanks to castorgodinho.

Bug: https://github.com/eclipse/mosquitto/issues/169
9 years ago
Roger A. Light 7761218d3c [170] Fix WS listeners not being able to bind to an IP.
Closes #170. Thanks to minghuadev.

Bug: https://github.com/eclipse/mosquitto/issues/170
9 years ago
Roger A. Light afc2c9951c [57] File missed from previous commit.
Bug: https://github.com/eclipse/mosquitto/issues/57
10 years ago
Roger A. Light 57da586703 Fix saving of persistence messages that start with a '/'.
Closes #151. Thanks to Andrew Chambers.

Signed-off-by: Roger A. Light <roger@atchoo.org>
10 years ago
Roger A. Light 3048c5ba0d Changelog update.
Fix reconnecting for bridges that use TLS on Windows.

Closes #154.

Thanks to Dmitry Kaukov.
10 years ago
Roger A. Light 6704df8061 Bridge config parameters can now contain a space
Closes #150.

Thanks to Sebastian Koch and Mikkel Kirkgaard Nielsen.

Bug: https://github.com/eclipse/mosquitto/issues/150
10 years ago
Frank Busse 10bb523854 fix 16 byte memory leak
Adds missing free for config->pid_file in mqtt3_config_cleanup.

Signed-off-by: Frank Busse <bb0xfb@gmail.com>
10 years ago
Frank Busse defbfbd185 DOS: use-after-free in ACL message handling
Removing the last message in queue because of an ACL leaves last_msg
in a corrupted state. Therefore an unauthorized attacker may cause a
segfault of the broker.

Signed-off-by: Frank Busse <bb0xfb@gmail.com>
10 years ago
Roger A. Light 69a08ab905 Fix string quoting in CMakeLists.txt. Closes #4. 10 years ago
Roger A. Light fda0cb3d45 Fix incorrect $SYS heap memory reporting when using ACLs. 10 years ago
Roger A. Light abc2f3f9de Network errors are printed correctly on Windows. 10 years ago
Roger A. Light a79412e3d8 Fix compile error from library keepalive handling. 10 years ago
Roger A. Light 1065a0f202 Will topic isn't truncated when using a mount_point. 10 years ago
Roger A. Light 6bac3f072c Reconnecting client doesn't start with mid=1 again. 10 years ago
Roger A. Light d9142c3974 [476314] Deliver queued WS client msgs on reconnect.
Thanks to Joking Young and Christoph Krey.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=476314
10 years ago
Roger A. Light af995d211d Fix client library keepalive handling.
Fix the case where a message received just before the keepalive timer
expired would cause the client to miss the keepalive timer.

Thanks to Graham Benton.
10 years ago
Roger A. Light f588075931 [485589] Close stdin etc. when daemonised.
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=485589
10 years ago
Roger A. Light eb514c9707 [487178] Obey mount_point when publishing wills.
Wills published by clients connected to a listener with mount_point defined
now correctly obey the mount point. This was a potential security risk
because it allowed clients to publish messages outside of their restricted
mount point. This is only affects brokers where the mount_point option is in
use.

Thanks to Lance Riley.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=487178
10 years ago
Roger A. Light af96c0b8fa [485143] Futher fix for broken win32 connections. 10 years ago
Roger A. Light 00491da031 [485143] Fix detection of broken connections on Windows.
Thanks to Pierre-Yves Boisbunon.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=485143
10 years ago
Roger A. Light 51f275bd02 Error messages for websockets init failure. 10 years ago
Roger A. Light 2549919413 Fix support for libwebsockets 1.22. 10 years ago
Roger A. Light 7aa653c42f Add support for libwebsockets 1.6. 10 years ago
Roger A. Light 80300f8fa1 [468987] Free unused topic tree elements.
Fix in 1.4.3 was incomplete.

Thanks to Guido Hinderberger et al.
10 years ago
Roger A. Light 26eac3c1ca Fix possible memory leak with bridges and SSL.
Fix possible memory leak if bridge using SSL attempts to connect to a
host that is not up.

Thanks to Ed Morris.
10 years ago
Roger A. Light 011de7ed19 Fix excessive calls to message retry check. 10 years ago
Roger A. Light 2597da17c2 [475807] Fix cross compiling of websockets.
Thanks to Tyler Brandon.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=475807
10 years ago
Roger A. Light 0c0961f6a4 [477571] Fix socket leak with bridges.
Don't leak sockets when an outgoing bridge connection with multiple
addresses is rejected.

Thanks to Johnny Egeland.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=477571
10 years ago
Roger A. Light 201bb1a04a Fix potential crash on libwebsockets error. 10 years ago
Roger A. Light 2172ffb56c [470253] Fix potential memory leaks.
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=470253
Also-by: Wun Yu <wuyun1984_1984@163.com>
10 years ago
Roger A. Light ab7f212b7e [468987] Free unused topic elements.
Reduces memory usage and CPU usage.

Thanks to Guido Hinderberger, Martin Rauscher and Michael Hekel.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=468987
10 years ago
Anmol Sarma 13d869b8df Avoid calls to strlen() when checking for empty strings.
Change-Id: I3de322006623483cbf20218da071a9da5d7b2e2b
Signed-off-by: Anmol Sarma <me@anmolsarma.in>
10 years ago
Roger A. Light e49e398eb3 Fix handling of outgoing QoS>0 messages for bridges.
Fix handling of outgoing QoS>0 messages for bridges that could not be
sent because the bridge connection was down.
10 years ago
Anmol Sarma 343e833fd9 Remove superfluous branch.
Signed-off-by: Anmol Sarma <me@anmolsarma.in>
10 years ago
Roger A. Light e0037b348f [465438] Fix incorrect behaviour for autosave_interval.
Thanks to Jaime Yu.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=465438
10 years ago
Roger A. Light dc5abcac95 [470660] Handle fragmented TLS packets without a delay.
Thanks to Martin Rauscher.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=470660
10 years ago
Roger A. Light 0733b3f68b Fix use of sprintf. 11 years ago
Roger A. Light cdb1cf9b13 Remove typos. 11 years ago
Roger A. Light 15b291eaa4 Remove unsigned comparison against <0.
Coverity CID 1292471.
11 years ago
Roger A. Light a6827df6c0 [467096] Fix incorrect bridge notification.
If a custom notification topic was used, the bridge status would be set
to 1 before a connection was attempted, this has been fixed.

Initial updates to the status topic are now only set once, when the
broker starts, rather than each time the bridge attempts to reconnect.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=467096
11 years ago
Roger A. Light 6f2fe06f0b [464811] Fix handling of payload lengths>4096 with websockets.
Thanks to Arjen van Elteren and Stephen Zeng.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=464811
11 years ago
Roger A. Light 121c2ca002 Broker will return CONNACK rc=5 when a client is not authorised.
This was being incorrectly set as rc=4.
11 years ago
Roger A. Light ec2fcce43b Don't send websockets messages if the message is queued. 11 years ago
Roger A. Light 11d0d887f0 Fix parsing of auth_opt_ arguments with extra spaces/tabs. 11 years ago
Roger A. Light cc7beb62a5 [465384] Fix crash on Windows when using bridges.
Thanks to Stefan Rosskopf.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=465384
11 years ago
Roger A. Light 21b372ed9e ACLs are now checked before sending a will message. 11 years ago
Roger A. Light 991f1173d7 Fix persistent db writing on Windows.
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=464779
11 years ago
Roger A. Light 1bdd6c36a8 Fix incorrect bridge connection notifications on local broker. 11 years ago
Roger A. Light 960b3ef32d Fix possible minor memory leak on acl parsing. 11 years ago
Roger A. Light dacee786be [463000] Use own type to simplify socket handling.
Means that SOCKET is used as the socket type everywhere on Windows.
11 years ago
Roger A. Light 7cd14725da Fix compiler warning. 11 years ago
Roger A. Light 502c3e7563 [461619] Disconnect idle websockets clients.
Websockets clients are now periodically disconnected if they have not
maintained their keepalive timer.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=461619
11 years ago
Roger A. Light 35b729909c [463241] Fix possible crash under heavy network load.
Thanks to Alexandre Zia.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=463241
11 years ago
Roger A. Light ccc8a81187 Ignore multiple spaces when parsing acl files. 11 years ago
Roger A. Light c6450ac265 [462154] Fix problems parsing config strings with leading spaces.
Thanks to Aidan Gill.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=462154
11 years ago
Roger A. Light 28404350c4 Fix possible crash when using pattern ACLs. 11 years ago
Roger A. Light 3a36ae843b Fix lws 1.3 detection. 11 years ago
Roger A. Light fcf91f9cd9 Fix compiling on Linux with CMake. 11 years ago
Roger A. Light 279b67bf8d Minor packaging related fixes. 11 years ago
Roger A. Light f04c10e609 Fix incorrectly committed change. 11 years ago
Roger A. Light ff3ebd969b Fix building on OS X. 11 years ago
Roger A. Light ff9c2087b1 Basic support for libwebsockets 1.2.x. 11 years ago
Roger A. Light 2098d6a392 Remove debug line. 11 years ago
Roger A. Light 91c1972c1f Consistent error message. 11 years ago
Roger A. Light db86809ee9 Add websockets logging options. 11 years ago
Roger A. Light 6fd38b8c47 Windows fixes. 11 years ago
Roger A. Light 3ed5c94038 Struct optimisations. 11 years ago
Roger A. Light 8b1560def0 Parse config strings as entire line. 11 years ago
Roger A. Light f781498c03 Ensure that file logging uses the correct username. 11 years ago
Roger A. Light 626857b20a Close and reopen log_dest file on HUP. 11 years ago
Roger A. Light c276fd9572 When using "log_dest file" the output file is now flushed periodically. 11 years ago
Roger A. Light 22e09ae613 [455402] Fix potential hang with pattern acls.
Fix hang if pattern acl contains a %u but an anonymous client connect.

Thanks to Christoph Krey.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=455402
11 years ago
Roger A. Light 45b8220a82 [458690] Fix build for WITH_BRIDGE=no
Thanks to Alexandre Zia.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=458690
11 years ago
Roger A. Light 8eda59c1d9 [452927] Fix bind()/listen() error reporting on Windows.
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=452927
11 years ago
Roger A. Light 1b4903b41e [431780] ACL files can contain a space in username/topic.
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=431780
11 years ago
Roger A. Light 153e6e6211 [452914] Drop root privileges after listeners started.
This means that TLS private keys can be restricted to the root user.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=452914
11 years ago
Roger A. Light 87d8e1f705 Bridge support for MQTT v3.1.1. 11 years ago
Roger A. Light 34176359c9 [452913] Prevent dereferencing of NULL string.
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=452913
11 years ago
Roger A. Light 96d98e620b Fix compiling on Apple. 11 years ago
Roger A. Light 0adb2ed217 [425835] Support for "hour client expiration times.
This allows shorter values for the persistent_client_expiration option.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=425835
11 years ago
Roger A. Light aca979a473 [457371] Fix building for WITH_TLS=no
Thanks to Micheal Laing.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=457371
11 years ago
Roger A. Light 8a18f577a6 Remove more unnecessary uses of calloc. 11 years ago
Roger A. Light 97849e8825 Remove unnecessary uses of calloc. 11 years ago
Roger A. Light cfe1156eb7 Reference count store structs when reloading from db.
Without this increment, a message could be incorrectly freed in rare
circumstances.
11 years ago
Roger A. Light b52e3311d2 Disconnect websockets clients properly.
context->state was being overwritten when websockets clients
attempted to disconnect, leaving them in limbo. This has been fixed.

Thanks to FeelyChau.
11 years ago
Roger A. Light faaf3edd02 Fix library linking with CMake.
When using CMake it wasn't possible to use libwrap due to a
configuration error. This has been fixed.

Thanks to Markus Rathgeb.
11 years ago
Roger A. Light 175794826b [456899] Broker: Add bridge_attempt_unsubscribe option.
The bridge_attempt_unsubscribe option has been added, to allow the sending
of UNSUBSCRIBE requests to be disabled for topics with "out" direction.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=456899
11 years ago
Roger A. Light 778bd4ca25 Clear store variable correctly here. 11 years ago
Roger A. Light 0e72d3cc32 Should check acl result for lack of success, not presence of error. 11 years ago
Roger A. Light f8f794c531 Allow expiring clients to be cleaned up. 11 years ago
Roger A. Light b30adbf792 Remove incorrectly committed file. 11 years ago
Roger A. Light fb588ef434 Print dlerror on library loading errors. 11 years ago