From d6be7ca2e588088f730064ecc4a34db633472ec6 Mon Sep 17 00:00:00 2001 From: emirpasic Date: Sat, 7 Mar 2015 18:29:48 +0100 Subject: [PATCH] - simplify String() method of linked list stack to make use of the Values() method --- stacks/linkedliststack/linkedliststack.go | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/stacks/linkedliststack/linkedliststack.go b/stacks/linkedliststack/linkedliststack.go index 0fcc49d..b9fb455 100644 --- a/stacks/linkedliststack/linkedliststack.go +++ b/stacks/linkedliststack/linkedliststack.go @@ -112,15 +112,10 @@ func (stack *Stack) Values() []interface{} { func (stack *Stack) String() string { str := "LinkedListStack\n" - element := stack.top - elementsValues := []string{} - for element != nil { - elementsValues = append(elementsValues, fmt.Sprintf("%v", element.value)) - element = element.next - } - for i, j := 0, len(elementsValues)-1; i < j; i, j = i+1, j-1 { - elementsValues[i], elementsValues[j] = elementsValues[j], elementsValues[i] + values := []string{} + for _, value := range stack.Values() { + values = append(values, fmt.Sprintf("%v", value)) } - str += strings.Join(elementsValues, ", ") + str += strings.Join(values, ", ") return str }