Don't free here, leads to potential double free.

src/read_handle_server.c

@@ -636,9 +636,7 @@ handle_connect_error:
 #ifdef WITH_TLS
 	if(client_cert) X509_free(client_cert);
 #endif
-	if(context){
+	/* We return an error here which means the client is freed later on. */
-		mqtt3_context_disconnect(db, context);
-	}
 	return rc;
 }
 

test/broker/06-bridge-reconnect-local-out.py

@@ -69,6 +69,7 @@ try:
                 rc = 0
     sock.close()
 finally:
+    time.sleep(1)
     broker.terminate()
     broker.wait()
     if rc:

test/broker/08-ssl-connect-no-identity.py

@@ -38,6 +38,7 @@ try:
 
     ssock.close()
 finally:
+    time.sleep(2)
     broker.terminate()
     broker.wait()
     if rc:

test/broker/08-tls-psk-bridge.py

@@ -62,8 +62,10 @@ try:
             rc = 0
     sock.close()
 finally:
+    time.sleep(1)
     broker.terminate()
     broker.wait()
+    time.sleep(1)
     bridge.terminate()
     bridge.wait()
     if rc:

test/broker/Makefile

@@ -4,6 +4,7 @@
 all :
 
 clean : 
+	-rm -f *.vglog
 	$(MAKE) -C c clean
 
 test-compile : 

test/mosq_test.py

@@ -25,6 +25,7 @@ def start_broker(filename, cmd=None, port=1888):
 
         if c is not None:
             c.close()
+            time.sleep(delay)
             return broker
     raise IOError