Fix potential memory leak in mosquitto_sub_topic_tokenise()

10 years ago · acb95f2f2e
parent 720d52d86e
commit acb95f2f2e
1 changed files with 3 additions and 3 deletions
--- a/lib/mosquitto.c
+++ b/lib/mosquitto.c
@ -1374,9 +1374,9 @@ int mosquitto_sub_topic_tokenise(const char *subtopic, char ***topics, int *coun
 				tlen = stop-start + 1;
 				(*topics)[hier] = _mosquitto_calloc(tlen, sizeof(char));
 				if(!(*topics)[hier]){
-					for(i=0; i<hier_count; i++){
+					for(j=0; j<hier_count; j++){
-						if((*topics)[hier]){
+						if((*topics)[j]){
-							_mosquitto_free((*topics)[hier]);
+							_mosquitto_free((*topics)[j]);
 						}
 					}
 					_mosquitto_free((*topics));