5a56f066a8
Change systemd unit files to create /var/log/mosquitto
...
This happens before starting the broker.
Also don't quit with an error if opening the log file isn't possible.
Closes #821 .
5 years ago
abb31ffe8d
Fix broker refusing to start if only websockets listeners were defined.
...
Closes #1740 . Thanks to OkenKhuman.
5 years ago
f46187d5e5
Add `mosquitto_client_protocol_version()` function.
...
This can be used by plugins to determine which version of MQTT a client
has connected with.
5 years ago
5481575f8b
Fix FormatMessage warnings for Windows.
...
From the FormatMessage() Win32 API documentation: "The lpBuffer
parameter is a pointer to an LPTSTR; you must cast the pointer
to an LPTSTR (for example, (LPTSTR)&lpBuffer)."
https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-formatmessage#parameters
This commit fixes warnings like these:
warning C4047: 'function': 'LPSTR' differs in levels of indirection from 'char **'
warning C4024: 'FormatMessageA': different types for formal and actual parameter 5
Signed-off-by: Sigmund Vik <sigmund_vik@yahoo.com>
5 years ago
a75d574870
Fix sys_tree macro stubs with no arguments.
...
This fixes Visual Studio compiler warnings like this one:
"warning C4003: not enough arguments for function-like
macro invocation 'G_MSGS_DROPPED_INC'"
Signed-off-by: Sigmund Vik <sigmund_vik@yahoo.com>
5 years ago
20972a2819
Add broker ready message.
...
Before this commit there was no good way to detect that the
Mosquitto broker was done with its startup phase on systems
without systemd.
On such systems it was tricky to e.g. start the broker from
a test where ports are dynamically assigned and one have to
deal with potential port conflicts. Without a way to know
that the broker is done with its startup phase, there was no
way to know if the broker was able to acquire the port (for
both IPv4 and IPv6) without waiting for some unknown period
of time (when many tests are run in parallel a single process
might be starved for resources).
With this new broker ready message it is easy for the parent
process to monitor the broker output and figure out when the
port was successfully acquired.
Signed-off-by: Sigmund Vik <sigmund_vik@yahoo.com>
5 years ago
abc191ad00
db_dump: Fix mosquitto_msg_store usage.
5 years ago
a07edaa4a0
db_dump: Print error when file not accessible.
5 years ago
6deb417804
Simplify db__message_store() interface.
5 years ago
3e595d557e
Add db__msg_store_free() for freeing stored messages.
5 years ago
e3e8dc4ea4
Allow send__pub{ack,rec,rel,comp} to send properties.
5 years ago
318dead6bf
Function to allow plugins to publish messages.
5 years ago
e54bac2a54
No need to pass separate username/password here.
5 years ago
73cc271d37
Allow auth plugin to see all logins, unless accepted by password file.
5 years ago
2e32634a95
DLT logging is now configurable at runtime with `log_dest dlt`.
...
Closes #1735 . Thanks to Brian Orpin.
5 years ago
2758401829
only link with libm on OpenBSD
...
fixes "ld: error: unable to find library -ldl"
Signed-off-by: Jasper Lievisse Adriaanse <jasper@humppa.nl>
5 years ago
4b541ad5ca
Fix usage message not mentioning v5.0.
...
Closes #1713 . Thanks to whnr.
5 years ago
6bd435d721
Fix possible assert crash associated with bridge reconnecting.
...
This only occurs when compiled without epoll support.
Closes #1700 . Thanks to Matthias Urlichs.
5 years ago
eae8c9aab4
Fix check when loading persistence file of a different version
...
Closes #1684 . Thanks to grekhss.
5 years ago
762ad432e8
Fix support for openssl 3.0
5 years ago
e755827f4f
Free outgoing client messages even for non-bridges.
5 years ago
ee7d1981ff
Merge branch 'rfc-bridge-local-clean' of git://github.com/etactica/mosquitto into etactica-rfc-bridge-local-clean
5 years ago
d3247a830a
Fix memory leak when connecting clients are rejected.
5 years ago
bfc82ea91a
Fix incorrect check.
5 years ago
4960fc0702
Don't disconnect clients that are already disconnected.
...
This prevents the session expiry being extended on SIGHUP.
Closes #1521 . Thanks to Christoph Krey.
5 years ago
c5d6f32341
Be more tolerant when loading persistence files.
5 years ago
eeaafed485
Fix memory leak when connecting clients rejected.
5 years ago
ff2b111cb3
Fix minor memory leak when load bridge prefixes.
5 years ago
4392320bc3
Fix memory leak when cleaning all shared subs.
5 years ago
ea47f6b0dc
Clearer client disconnection message.
5 years ago
5908585afd
Fix mosquitto_passwd -b not updating passwords for existing users
...
Closes #1664 . Thanks to Leon Kiefer.
6 years ago
3758e0c328
Fix mosquitto_passwd not being able to create pwfile with -b.
6 years ago
cef9d891ae
Tidy up main().
6 years ago
c72dd39f92
Allow MQTT v5.0 outgoing bridges to fall back to MQTT v3.1.1
...
This applies if connecting to a v3.x only broker.
6 years ago
de25ff694e
Report invalid bridge prefix+pattern combinations at config parsing time
...
Rather than letting the bridge fail later.
Issue #1635 . Thanks to pokerazor.
6 years ago
4ab0f4bd39
Fix bundled deps option not being propagated to library.
...
Issue #1641 .
6 years ago
986bf89f47
Prototype separate poll/epoll files.
6 years ago
c3e824ee22
Remove duplicate strlen() calls.
6 years ago
95faff36aa
Fix ref counting of retained messages.
6 years ago
0b7b7389b0
Remove duplicate UTF-8 check
...
All strings are already validated in packet__read_string().
6 years ago
07d73c7e3a
bridge: support bridge local clean session
...
This adds the ability to separating bridge clean session settings between
the local and remote endpoints. Some broker implmentations refuse to allow
non-clean sessions, as they don't support storing messages to be sent to
the connecting broker. However, this doesn't mean that the local
broker can't be queueing messages to send _out_ to the remote broker.
This PR adds a new bridge connection setting, local_cleansession, that
allows controlling this split. Naming is chosen to be local_ in keeping
with the other local_ settings for bridges.
A test for the six cases of queued/not queued messages in both
directions is added, but v5 testing is currently disabled. The changes
to support the split are ~independent of protocol version.
Signed-off-by: Karl Palsson <karlp@etactica.com>
6 years ago
24e34434a4
Move SSL prepare and accept operations out of deep loop
...
Since all resources are ready, do not need lookup again.
Signed-off-by: Michael Liu <michael.liu.point@gmail.com>
6 years ago
7953649b1c
Fix potential memory leak.
...
WebSocket context may lost since db->ll_for_free = NULL; operation on the bottom of context__free_disused() function.
Signed-off-by: Michael Liu <michael.liu.point@gmail.com>
6 years ago
c84d175b3d
Fixes for the poor souls stuck on <c99.
...
Closes #1622 .
6 years ago
c175e836a7
Print openssl error when unable to load server key.
6 years ago
d96543c0b8
Merge branch 'fixes' into develop
6 years ago
b0a065f790
Update changelog. Release page. Bump copyright.
6 years ago
0c68c20d2b
Fix `mosquitto_client_protocol()` returning incorrect values.
6 years ago
db02c9162d
Add plugin that prints out calls, to help debugging.
6 years ago
032af6bf69
Add missing header
6 years ago
c4e41f3444
Back port db_dump from develop.
...
Closes #1519 . Thanks to Christoph Krey.
6 years ago
2a8c1d03f5
Merge branch 'coverity-fixes' into fixes
6 years ago
078ad752cd
cmake: add ADNS enable/disable dynamic support
...
Signed-off-by: Gianfranco Costamagna <costamagnagianfranco@yahoo.it>
6 years ago
e9a7150031
Bugfix: enabling DLT was overriding everything else on linker flags because of error in cmake set keyword
...
Signed-off-by: Gianfranco Costamagna <costamagnagianfranco@yahoo.it>
6 years ago
07c54627e9
Print OpenSSL errors in more situations
...
Covers when loading certificates fails, or there are ENGINE problems.
Closes #1552 . Thanks to Michael Richardson.
6 years ago
27b4518d7e
Improve password file parsing in the broker and mosqitto_passwd.
...
Closes #1584 . Thanks to panava.
6 years ago
ed5db1bd6b
Fix `bind_interface` not working for the default listener.
...
Closes #1533 . Thanks to Markus Gothe.
6 years ago
e188a6b500
More whitespace trimming fixes/consolidation.
6 years ago
32969169f7
Trim whitespace from acl topics.
6 years ago
70fd600c3a
Fix trailing whitespace not being trimmed on acl users.
...
Closes #1539 . Thanks to CliveJL and LeonPoon.
6 years ago
9a0de5ef61
Free log_timestamp_format on exit.
...
Closes #1523 . Thanks to Basavesh Shivakumar.
6 years ago
11ece604c4
Merge branch 'bugfix-MemLeak_in_handle_unsubscribe' of git://github.com/panava/mosquitto into panava-bugfix-MemLeak_in_handle_unsubscribe
6 years ago
3220790790
Merge branch 'bugfix-MemoryLeak_in_persist_read' of git://github.com/panava/mosquitto into panava-bugfix-MemoryLeak_in_persist_read
6 years ago
50735afb5b
Fix for internal logging not printing.
6 years ago
618413e1d2
Resource leak in persist_read.c
...
Reason: In lines 435 and 439, the function returns without calling closing
fptr which was opened at line 399.
Fix: I added fclose(fptr) statements before each of the returns.
Signed-off-by: Panagiotis Vasilikos <panagiotis.vasilikos@alexandra.dk>
6 years ago
9ae38788dc
Fix config->user not being freed on exit.
...
Closes #1564 . Thanks to back1127.
6 years ago
812c0636d5
Satisfy valgrind when exiting on error.
...
This is when due to not being able to open a listening socket, solved by
calling freeaddrinfo in the error cases.
Closes #1565 . Thanks to back1127.
6 years ago
e7c9f009bd
Strip whitespace from end of config file string options.
...
Closes #1566 . Thanks to kollokollo.
6 years ago
49bf788862
Memory leak in handle_unsubscribe.c
...
Reason: In line 70, the memory allocation for the pointer reasons_codes may
result to a memory leak due to the many returns (e.g as the one in line 78)
occuring in the program's path until reaching the mosquitto__free at line 122.
Fix: I added a mosquitto__free(reason_codes) statement before each return
statement that could result to a memory leak
Signed-off-by: Panagiotis Vasilikos <panagiotis.vasilikos@alexandra.dk>
6 years ago
0f7052564c
Memory leak in handle_unsubscribe.c
...
Reason: In line 70, the memory allocation for the pointer reasons_codes may
result to a memory leak due to the many returns (e.g as the one in line 78)
occuring in the program's path until reaching the mosquitto__free at line 122.
Fix: I moved the memory allocation code block (lines 69-73) just before
the line 102. This is the first place the pointer reason_codes is used, while
the following mosquitto__free operators free the allocated memory correctly.
Signed-off-by: Panagiotis Vasilikos <panagiotis.vasilikos@alexandra.dk>
6 years ago
5528dde56a
Fix possible null dereferences.
6 years ago
05ec02b3f3
Remove dead values.
6 years ago
18f0508a6e
Fix dereference before null check.
...
Coverity Scan 1405815.
6 years ago
db62f9843f
Fix unused value being overwritten.
...
Coverity Scan 1400727.
6 years ago
d452ea138b
Use presence of password file as indicator for authentication checks.
...
Previously, authentication checks would only take place if usernames
were defined in the password file.
Closes #1545 . Thanks to Timothy Godfrey.
6 years ago
b6119bb759
Check ACL patterns for validity when loading.
...
Closes #1539 . Thanks to Leon Poon.
6 years ago
e5561cd09e
Fix db_dump compilation.
...
Closes #1520 .
6 years ago
c8789180f3
Fix session expiry with very large expiry intervals.
...
Closes #1525 . Thanks to Christoph Krey.
6 years ago
8a6f179c83
Fix comment.
6 years ago
3f0c202aa5
Reduce heap allocation churn when tokenising topics.
6 years ago
c0443637e8
Merge branch 'master'
...
Conflicts:
ChangeLog.txt
config.mk
src/context.c
src/loop.c
src/subs.c
test/broker/01-connect-bad-packet.py
test/broker/02-subpub-qos1-bad-pubcomp.py
test/broker/02-subpub-qos1-bad-pubrec.py
test/broker/02-subpub-qos2-bad-puback-1.py
test/broker/02-subpub-qos2-bad-puback-2.py
test/broker/02-subpub-qos2-bad-pubcomp.py
test/broker/02-subpub-qos2.py
test/broker/07-will-null-topic.py
6 years ago
6dec2b468b
Remove redundant expiry checks
...
This is all now handled in session_expiry.c, through session expiry interval/time.
6 years ago
a46b45b006
Fix persistent_client_expiration not being used
...
Closes #1494 . Thanks to Christoph Krey.
6 years ago
d92360dd8e
Split sub and retain trees.
6 years ago
d003fed383
MQTT v5 bridges can handle "retain-available" being false.
6 years ago
2af260ba58
Add `bridge_outgoing_retain` option
...
This allows outgoing messages from a bridge to have the retain bit
completely disabled, which is useful when bridging to e.g. Amazon or
Google.
6 years ago
05171b266d
Fix TLS Websockets clients not receiving messages.
...
This can occurs after one client takes over a previous connection.
Closes #1489 . Thanks to Bas Verhoeven.
6 years ago
b622aaeee4
Fix messages with an expiry interval missing the property.
...
They would be be sent without an expiry interval property just before
they were expired.
Closes #1464 . Thanks to Dustin Sallings.
6 years ago
06a27e799f
Fix retained messages with an expiry interval not being expired.
...
This happened after being restored from persistence.
Closes #1464 . Thanks to Dustin Sallings.
6 years ago
d49988fa6f
Rejig unix socket support.
6 years ago
253326dcc9
Fix problems with reloading config when `per_listener_settings` was true.
...
Closes #1459 . Thanks to Thomas Markin Klein.
6 years ago
b660283e64
Basic MQTT v5 support for bridges.
...
This gives equivalent behaviour as for v3.1.1/v3.1 bridges, there is no extra functionality yet.
6 years ago
847c3f1f8b
Move bridge on connect code to bridge.c.
6 years ago
1ab19f2b3d
Make error messages clearer when bridge misconfigured
6 years ago
17c32d89d9
Restrict access to unix socket.
6 years ago
43a692dfbe
Add new files to cmakelists.
6 years ago
499e2f2e98
Add support for unix sockets to broker, lib, and clients.
6 years ago
fad184c9c2
Bridge remapping refactoring and tests.
6 years ago
8463c33720
Refactor property remaining length calculation.
6 years ago
cfacd961c9
Only a single CRL could be loaded at once. This has been fixed.
...
Closes #1442 . Thanks to charlemagnelasse.
6 years ago
c471dfb201
Fix sub topics being limited to 200 chars instead of 200 levels
...
Closes #1441 . Thanks to Christoph Krey.
6 years ago
b942b73b6d
Fix incorrect memory tracking causing problems with memory_limit option.
...
Closes #1437 . Thanks to Guillaume Bour.
6 years ago
4db1e80410
More allow_zero_length_clientid fixes.
...
Closes #1429 . Thanks to Dustin Sallings.
6 years ago
539c1b9bcb
Tests for zero length client id, plus fix for one case where it was allowed
6 years ago
54ed3c0fc9
Merge branch 'master' into develop
6 years ago
6a01453ce0
Build fixes.
6 years ago
9584463c75
Fix potential crash when reloading config.
...
Closes #1424 , #1425 . Thanks to JinPingChng and peteakalad.
6 years ago
1a8c44b84f
Fix regression on use of `mosquitto_connect_async()` not working.
...
Closes #1415 and #1422 . Thanks to Karl Palsson, Till Zimmermann and Liam Fry.
6 years ago
096380fbdc
Add workaround for libwebsockets 3.2.0.
6 years ago
2fd7f5270a
mosquitto_passwd returns 1 on an error condition
...
When attempting to update a user that does not exist.
Closes #1414 . Thanks to kdgde.
6 years ago
1066750931
Restrict topic hierarchy to 200 levels to prevent possible stack overflow.
...
Closes #1412 . Thanks to Ryan Shaw.
6 years ago
0a0ad4cd6c
Fix for old libwebsockets versions.
6 years ago
ce68040f22
Refuse to compile with lws 3.2.0.
6 years ago
8f6ac1b64a
Fix for websockets regression.
6 years ago
5941291bd5
Fix build WITH_TLS=no
6 years ago
9ad5fe7d95
Fix repeated "Error in poll" messages on Windows.
...
This occurs when only websockets listeners are defined.
Closes #1391 . Thanks to stopak.
6 years ago
4dc98c4cef
Fix CRL file not being reloaded on HUP.
...
Closes #35 .
6 years ago
31f09d1206
Merge pull request #1405 from woelfman/fix-engine-key-uri
...
Fix usage of tls_engine and tls_keyform.
6 years ago
39803e538f
Fix usage of tls_engine and tls_keyform.
...
The current implementation does not properly forward the engine
parameters to OpenSSL causing OpenSSL to incorrectly attempt to open the
engine key uri as a file.
Sponsored-by: Trimble, Inc.
Signed-off-by: Matt Woelfel <matt@woelfware.com>
6 years ago
034324c46d
Fix websockets 3.2 causing slow connection on non-websockets listeners
...
Closes #1406 . Thanks to pbrenna.
6 years ago
5fd92cbfbd
Further fix for #1401 .
6 years ago
3c35c6cdd9
Fix Will not being sent if will delay greater than session expiry.
...
Closes #1401 . Thanks to Will Lisac.
6 years ago
f1516f86cb
Improve error messages in some situations when clients disconnect.
...
Reduces the number of "Socket error on client X, disconnecting"
messages.
6 years ago
779c6cc234
Fix leak introduced in previous commit.
6 years ago
f6b22f8248
Fix clients using `use_identity_as_*` being disconnected on SIGHUP.
...
Closes #1402 . Thanks to twegener-embertec.
6 years ago
4658dba6b3
Fix slow websockets performance when sending large messages.
...
Closes #1390 . Thanks to aalibasic.
6 years ago
4c4ca38938
Fix support for libwebsockets 3.x.
6 years ago
abfdc2f8a6
Remove useless if statement
...
If statement for detecting if a pointer is NULL
is totally unnecessary.
Signed-off-by: YangHau <vulxj0j8j8@gmail.com>
6 years ago
570c3674fb
Drop privs to nobody if mosquitto user does not exist.
6 years ago
1c1ccaee52
Merge branch 'master' into develop
6 years ago
cbced051e7
Better check for printable db_dump payloads.
6 years ago
9c3e6b4ccc
Remove debug printfs.
6 years ago
50695f8103
Fix v5 DISCONNECT packets with remaining length == 2.
...
These were being treated as a protocol error.
Closes #1367 . Thanks to Frank Pagliughi.
6 years ago
c269e6f019
db_dump: Update for version 5 file format
...
Closes #1320 . Thanks to Christoph Krey.
6 years ago
07d2504bf5
Merge pull request #1254 from ccvca/fix_passwd_len
...
Fix password input when MAX_BUFFER_LEN is not 1024 in mosquitto_passwd.c
6 years ago
efc8ed39af
Fix incoming msgs not being removed when there are no subs
...
Fix incoming messages not being removed for a client if the topic being
published to does not have any subscribers.
Closes #1322 . Thanks to Yannic Schröder.
6 years ago
696a9b8019
Fix incomgin QoS 2 with max_inflight_messages set to 1.
...
Closes #1332 . Thanks to xmas79.
6 years ago
13ac1080a0
Refactoring bridge code
...
This separates out a good amount from the main loop code.
6 years ago
d17d7c9229
Fix persistent clients being incorrectly expired on Raspberry Pis.
...
Closes #1272 . Thanks to BowenMarmot and addendumE.
6 years ago
0a5fbc403b
Fix plugin psk_key_get for v4
...
Signed-off-by: Matevz Mihalic <matevz.mihalic@gmail.com>
6 years ago
587debc013
Fix incoming/outgoing quota problems for QoS>0.
6 years ago
142d07f45a
Fix MQTT v5 overlapping subscription behaviour.
...
Clients now receive message from all matching subscriptions rather than
the first one encountered, which ensures the maximum QoS requirement is
met.
6 years ago
de695af8c0
Fix zero length client ids being rejected for MQTT v5 clients.
...
This was happening when clean start was set to true.
6 years ago
e51e40e95c
Fix incorrect shared subscription topic of '$shared.'
6 years ago
b42bb99ba6
Disable TLS renegotiation.
...
Client initiated renegotiation is considered to be a potential attack
vector against servers.
Closes #1257 . Thanks to Daniele Sluijters.
6 years ago
44d170053d
Merge pull request #1255 from etactica/ssl-fixes
...
Ssl fixes for ENGINE and UI includes
6 years ago
96d0a26902
Only add to disused if session expiry is 0.
6 years ago
5088202529
Fix persistent Websockets clients not receiving messages.
...
This occurs after they reconnect, having sent DISCONNECT
on a previous session.
Closes #1227 . Thanks to usernametaken.
6 years ago
3dd8eb722b
Colour internal logs for visibility.
6 years ago
00eee59ad9
Add 'extern "C"' on public headers.
...
mosquitto_broker.h and mosquitto_plugin.h
Thanks to Wolfgang Petroschka.
Closes #1290 .
6 years ago
a900e3a1a7
Mention mosquitto_broker.h in mosquitto_plugin.h.
6 years ago
f974b91084
Consistent ref counting inc and dec functions.
6 years ago
b4dfeb3767
Fix MQTT v5 clients not being able to specify a password without a username.
...
Thanks to Erik Moqvist.
Closes #1274 .
6 years ago
999c478c88
Fixes for bug #1273
...
* Fix Will message for a persistent client incorrectly being sent when the client reconnects after a clean disconnect.
* Fix Will message for a persistent client not being sent on disconnect.
* Fix mosquitto_pub not using the `-c` option.
Thanks to Yannic Schröder.
Closes #1273 .
6 years ago
ef3e52d40b
Fix default max_topic_alias listener config not being used.
...
This was not being copied to the in-use listener when compiled without
TLS support.
6 years ago
cd3877e628
Fix detection of incoming v3.1/v3.1.1 bridges.
...
Closes #1263 . Thanks to vrst37.
6 years ago
22303848e2
ssl: support openssl with ENGINE support disabled.
...
Alternatively, just drop support for this config.
Signed-off-by: Karl Palsson <karlp@etactica.com>
7 years ago
324ed6be76
Fix password input when MAX_BUFFER_LEN is not 1024 in mosquitto_passwd.c
...
Signed-off-by: Christian von Arnim <christian.vonarnim@gmail.com>
7 years ago
e742c1c2f1
Fix $SYS/broker/version being incorrectly expired after 60 seconds.
...
Close #1245 . Thanks to Christoph Krey.
7 years ago
f64d3b1e5c
Fix broker originated messages not being sent.
...
This occurred when `check_retain_source` was set to true.
Closes #1245 . Thanks to Christoph Krey.
7 years ago
a9f17cea95
Fix Will message not allowing user-property properties.
7 years ago
eebdbc86c4
Fix access after free when v5 client with Will message disconnects.
...
The Will message has as its first property one of content-type,
correlation-data, payload-format-indicator, or response-topic.
Closes #1244 . Thanks to Christoph Krey.
7 years ago
42fb2f5538
Fix build for WITH_TLS=no.
...
Closes #1250 . Thanks to bmparr.
7 years ago
439575475c
Use CMAKE_INSTALL_* variables when installing in CMake.
...
Closes #1049 . Thanks to Greg Troxel.
7 years ago
efa649f451
Don't call ldconfig in CMake scripts.
...
Closes #1048 . Thanks to Greg Troxel.
7 years ago
3b4a5419c3
Build fixes around CFLAGS et al.
...
- Split CFLAGS and CPPFLAGS, and LDFLAGS and LDADD/LIBADD.
- test/unit now respects CPPFLAGS and LDFLAGS.
Closes #1232 . Thanks to Greg Troxel.
7 years ago
4dcd977932
Windows build fixes.
7 years ago
449103e960
Merge remote-tracking branch 'refs/remotes/origin/fixes'
...
Conflicts:
ChangeLog.txt
7 years ago
3e6cb42a40
Fix minor Coverity issues
...
1400727 - unused value
1400726 - dereference after null check
1400728 - derefence before null check
7 years ago
689989cc56
Fix inflight quota inc/dec for both broker and library.
7 years ago
6438ce861e
Minor build variant fixes.
7 years ago
32fde3885c
Fix missing errors for websockets.
7 years ago
8531cb1d79
Separate broker message queues into in/out.
...
This allows and includes better flow control handling for QoS>0.
7 years ago
baf1909ffb
Improve some messages when client disconnects.
7 years ago
fb1979c0ea
Fix build on SmartOS due to missing IPV6_V6ONLY.
...
Thanks to Matt Ingenthron.
Closes #1212 .
7 years ago
77aaec686e
Merge pull request #1224 from omenlabs/ALPN
...
Bridge TLS Application-Layer Protocol Negotiation
7 years ago
638ab2f969
Fix unexpected behaviour when reusing a mid after a publish is denied.
7 years ago
8a651ff6c3
Remove remnant from before the conversion to utlist.
7 years ago
ad3b7ec778
Fix Coverity Scan 1400486-1400487. Unused values.
7 years ago
0d3c7fe778
Fix Coverity 1302840. No effect comparison.
7 years ago
e4d0d52b01
Fix Coverity Scan 1400483-1400485.
...
Logically dead code.
7 years ago
c011be62a4
Bridge TLS Application-Layer Protocol Negotiation
...
In order to connect to brokers that support both websockets and
mqtt on the same port (such as Amazon IoT), we need to set an
application for the SSL context. This change allows the specification
of an application by using the `bridge_alpn` configuration token.
Signed-off-by: John Hickey <jjh-github@daedalian.us>
7 years ago
2e7dcee342
Multistep auth, plus reauth, plus tests.
7 years ago
c1776a0b39
Add reauth parameter for extended auth.
7 years ago
0f6e51d582
Code and tests for returning single stage auth data back to client.
7 years ago
494f35bd8d
Add mosquitto_set_username() plugin function.
7 years ago
a29a7dadc6
Basic plugin support for single step extended auth.
7 years ago
da84b9a983
Restrict what packets are allowed in what client state.
7 years ago
758e1edbe7
Handle error condition correctly.
7 years ago
fb8a2baaad
Refactor client msgs to use utlist to reduce code complexity.
7 years ago
8097ec24f9
Fix some property leaks.
7 years ago
fe854d3a64
Refactor handle__connect() ahead of extended auth changes.
7 years ago
73cd44ac7f
Move handle__disconnect() to its own file.
7 years ago
ec3fd361be
https links where possible.
7 years ago
75c2a39d2c
Send topic alias maximum from the broker.
7 years ago
12e5efbee2
Typo.
7 years ago
ea046c2405
Merge branch 'master' of git://github.com/LarsVoelker/mosquitto into LarsVoelker-master
7 years ago
834ffdf82b
Fix Coverity Scan defect 1400435.
7 years ago
0ca093060c
Fix Coverity Scan defect 1400433. Integer overflow.
7 years ago
9faad1e078
Fix a variety of scan-build warnings.
7 years ago
67707b819d
Fix some -Wextra compiler warnings.
7 years ago
2a5995106a
Fix Coverity Scan defect 140436. Null dereference.
7 years ago
87197bf9d4
Fix Coverity Scan defect 1400441, dereference of pointer after earlier null check.
7 years ago
42732f4cca
Fix mosquitto_passwd segfault on corrupt file.
...
Thanks to srasku-ge.
Closes #1207
7 years ago
43c159b9a5
Support and tests for saving message expiry interval.
7 years ago
61fe26474e
Test and fix for client message prop persistence.
7 years ago
5841da2c36
Tests for persisting message store properties.
7 years ago
efb20625fb
Code and tests for persisting client msg properties.
7 years ago
c95ae6a6fd
Remove one instance of recursion.
7 years ago
48253bc12c
Persist message store publish properties.
7 years ago
2f15a7be2b
Add subscription-identifier and options to persistence.
7 years ago
214a5f3aab
v5 persistence file format
...
This includes changes to improve read/write performance.
It is not complete, and will have further changes to add properties and anything else required for MQTT v5.
7 years ago
a0e54ac065
Function for reading persist file chunk header.
7 years ago
ee5412b060
Persist write fix.
7 years ago
a50d129a3c
Fix db_dump.
7 years ago
e249ca7e91
Separate the persistence actual writing functions.
7 years ago
7a53b28080
Start of persistence writing tests.
7 years ago
54a35ed0ed
Free clients with >0 session expiry on exit.
7 years ago
94450eb8bc
Keep log open until we are ready to quit.
7 years ago
8024a30d1d
Fix potential leak.
7 years ago
c90bd4e0c6
Add helper function for internal debug logging.
7 years ago
b29c8ced55
Fix compilation warning for WITH_WEBSOCKETS=no.
7 years ago
ad2ce6c4e6
Add internal logging type, for development debugging.
7 years ago
c5699da5ce
Don't remove unused websockets contexts until lws is finished with them.
7 years ago
0ced003880
Always remove from by_id when adding to disused list.
7 years ago
320ddc1303
Merge branch 'master'
...
Conflicts:
CMakeLists.txt
ChangeLog.txt
client/Makefile
config.mk
installer/mosquitto.nsi
installer/mosquitto64.nsi
lib/mosquitto.h
lib/mqtt3_protocol.h
lib/util_mosq.c
set-version.sh
snap/snapcraft.yaml
src/bridge.c
src/database.c
src/handle_connack.c
src/loop.c
src/persist.c
test/broker/Makefile
7 years ago
a7d0660749
Separate out persist reading code from restoring code.
7 years ago
110f4aada6
Don't overwrite disused client state.
7 years ago
9411d94842
Start of tests for persistence reading.
7 years ago
b6356735b4
Split persist read/write into separate files for easier testing.
7 years ago
c944f840a6
Don't advertise shared subs as unavailable any more.
7 years ago
8a8d13cf96
Shared subscription support.
7 years ago
173b209bd8
Remove unnecessary calls to time().
7 years ago
89f51aa54a
Search sub topics, don't iterate (where possible).
7 years ago
2dd24449ad
Fix "unused parameter" warnings.
7 years ago
0941638143
Fix signed/unsigned comparion warnings.
...
Closes #1196 .
7 years ago
b82370a997
Free clients with session expiry > 0 on exit.
7 years ago
08249313a4
Don't leak sockets.
7 years ago
1a234323a3
Add support for custom log timestamps.
...
Closes #1121 .
7 years ago
e9350fbb56
print error when listener bind address is not valid
...
Signed-off-by: Vinod Kumar <kumar003vinod@gmail.com>
7 years ago
a57bba0aae
Don't use uhpa for topics, incompatible with uthash.
7 years ago
2ea97a6cd9
Check for authentication method on CONNECT, and reject.
7 years ago
ac91144495
Session expiry interval support - not working for file persistence.
7 years ago
cd07c2b802
Windows build fixes.
7 years ago
105ad17dc6
Tests and support for QoS 1 reporting of no subscribers on publish.
7 years ago
6a1ac70ee6
Disallow writing to $ topics where appropriate.
7 years ago
1d4bf55165
Tidy previous commit and add to changelog.
7 years ago
bb6da93e93
Merge pull request #993 from bbabbi01/origin/develop
...
Implement DLT logging
7 years ago
ce31269e05
Update changelog, bump version, bump copyright year.
7 years ago
7207041428
Fix delayed bridge local subs causing missing messages.
...
Closes #1174 . Thanks to beville.
Bug: https://github.com/eclipse/mosquitto/issues/1174
7 years ago
acf478eca2
Fix broken mosquitto_passwd on FreeBSD.
...
Closes #1032 . Thanks to jkoopman, Joseph Benden and Ari Suutari.
Bug: https://github.com/eclipse/mosquitto/issues/1032
7 years ago
a6f845bc67
Fix openssl deprecated function use.
7 years ago
4490d06a63
Coverity fixes.
...
1398654, 1398656 - lib missing unlock on fatal protocol error
1398655 - broker potential double free on startup after fatal persist
error.
7 years ago
d3d6f3a980
Fix compiling with openssl < 1.1.1.
7 years ago
463de0a2c1
Make error messages for missing config file clearer.
7 years ago
0632549ce9
Doc improvements for websockets_header_size.
7 years ago
1aaf5f2348
Add websockets_headers_size option
...
Signed-off-by: Pierre Fersing <pierre.fersing@bleemeo.com>
7 years ago
1924afe49e
Add explicit support for TLS v1.3 and drop TLS v1.0.
7 years ago
130ddf47f7
Add `dhparamfile` option, to allow DH parameters to be loaded.
...
This is for Ephemeral DH support on listeners.
7 years ago
4564ff1232
Set umask for temp file.
7 years ago
87b3ca35f1
Use mkstemp with mosquitto_passwd on non-Windows.
7 years ago
48d731ecb5
Use better random numbers for everything, where possible.
7 years ago
dfbd33e0f4
Update documentation for bridge backup, plus tweaks
...
Sets default to use the backoff mechanism.
7 years ago
87eb535307
bridge: add decorrelated jitter backoff mechanism
...
Signed-off-by: Abilio Marques <abiliojr@gmail.com>
7 years ago
72941db546
Coverity fixes
...
1399064
1399065
1398655
1398656
1398654
1399067
1399066
1399063
1399060
1399059
1399068
1399062
1398657
1398653
1302848
1302847
1399070
7 years ago
208c3d3e85
Allow binding a listener to a specific network interface
...
Signed-off-by: Steven Lawrance <stl@koffein.net>
7 years ago
b2c0c3d573
Handle DISCONNECT with will.
7 years ago
3b6b6d5fa8
Test improvements
...
And some related fixes.
7 years ago
c506c8335b
Will delay tests and implementation.
7 years ago
b0c60fb6e1
Separate will reading code.
7 years ago
5aabc171b0
Merge branch 'mqtt5' into develop
7 years ago
e862a047a8
Rework TLS engine support.
7 years ago
20894fcbce
Add engine private key password support
...
Some OpenSSL engines (selectable via tls_engine option) may require a
password to make use of private keys created with them in the first place.
The TPM engine for example, will require a password to access the underlying
TPM's Storage Root Key (SRK), which is the root key of a hierarchy of keys
associated with a TPM; it is generated within a TPM and is a non-migratable
key. Each owned TPM contains a SRK, generated by the TPM at the request
of the Owner. [1]
By default, the engine will prompt the user to introduce the SRK password
before any private keys created with the engine can be used. This could
be inconvenient when running on an unattended system.
Here's where the new tls_engine_kpass_sha option comes in handy. The user
can specify a SHA1 hash of its engine private key password via command
line or config file and it will be passed on to the engine directly.
This commit adds support for both clients (libmosquitto) and broker.
[1] https://goo.gl/qQoXBY
Signed-off-by: Nicolás Pernas Maradei <nicopernas@gmail.com>
7 years ago
d5f039ec7c
Add TLS engine and keyform support to mosquitto
...
Add same OpenSSL engine support to mosquitto (server side) previously added to
client side only.
Signed-off-by: Nicolás Pernas Maradei <nicopernas@gmail.com>
7 years ago
c3c8c99f5d
Fix dropping oversize messages for QoS>0.
7 years ago
1d17ced449
Broker configurable max_packet_size
...
Plus tests.
7 years ago
1877f8a326
Tests and implementation for maximum packet size.
...
This is for broker outgoing connack and publish packets only.
7 years ago
8db16591fa
Test and fix for subscription identifiers not being updated.
...
Closes #1169 . Thanks to Christoph Krey.
7 years ago
66c1e2ccf0
Add mosquitto_unsubscribe_multiple(), plus tests.
7 years ago
1479c57e34
v5 report reason code=no sub when unsubscribing.
7 years ago
1ec0cea34a
Fix missing reason_code on v5 UNSUBACK.
...
Closes #1167 . Thanks to Christoph Krey.
7 years ago
5e8199323b
Fix clients being disconnected when ACLs are in use.
...
This only affects the case where a client connects using a username, and
the anonymous ACL list is defined but specific user ACLs are not
defined.
Closes #1162 . Thanks to quonb.
7 years ago
8350956a08
Make include_dir sort usefully case sensitive.
7 years ago
321e566af6
Fix unref'd messages being saved to the persistence file.
...
This was leaving dangling messages that were never freed.
Closes #389 . Thanks to pjchx.
7 years ago
084062c85e
Merge branch 'fixes' into mqtt5
7 years ago
9999faf9da
Add rewritten build test script and remove some build warnings.
7 years ago
04e89450c0
Don't require C99 compiler.
7 years ago
715da28602
Fix include_dir not sorting config files before loading.
...
Thanks to momoskitto.
7 years ago
2e1c2c430f
`per_listener_settings true` must come before other security settings.
...
Produce error if this is not the case. Closes #1164 , thanks to
momoskitto.
7 years ago
9378016b19
Fix build failure when using WITH_ADNS=yes
7 years ago
05458eb35d
Fix some unused variable warnings.
7 years ago
1c075988ca
Log message for disconnecting a client with invalid UTF-8 topic.
...
Closes #1144 . Thanks to Kris Mattheus.
7 years ago
17b52bd5d1
Windows: Fix possible crash when client disconnects.
...
Closes #1137 . Thanks to Kris Mattheus.
7 years ago
d6a690aa8d
Fix Will not being sent for Websockets clients.
...
Closes #1143 . Thanks to salcedo.
7 years ago
29a1936c77
Fix spaces not being allowed in the bridge remote_username option.
...
Closes #1131 . Thanks to beville.
7 years ago
c40957a7d8
Fix and tests for CVE-2018-12546.
7 years ago
d8505624d0
Fix and tests for security bug #541870 .
7 years ago
36b5421c59
Fix and tests for security bug #543401 .
7 years ago
84d5028c2e
Include sys/socket.h for AF_INET definition
...
Without this, mosquitto doesn't build on FreeBSD with websockets enabled
Signed-off-by: Steven Lawrance <stl@koffein.net>
7 years ago
5236295159
Handle mismatched handshakes properly.
...
For example, a QoS1 PUBLISH with QoS2 reply.
7 years ago
78259850ed
ignore inline comments while parsing optional config params
...
Signed-off-by: Vinod Kumar <kumar003vinod@gmail.com>
7 years ago
be9c1071b0
Fix compilation when openssl deprecated APIs are not available.
...
Closes #1094 . Thanks to Rosen Penev.
7 years ago
70c4097b6f
Fix comparison of boolean values in CMake build.
...
Closes #1101 . Thanks to Mojca Miklavec and Andrew L. Moore.
7 years ago
873ffce27a
Send DISCONNECT on invalid topic alias, plus test.
7 years ago
5e7f43c9ea
Temporarily disable all extended AUTH.
7 years ago
6b977fa198
Test and fixes for expiring retained messages.
7 years ago
ca3782b38d
Test and fixes for will message expiry interval.
7 years ago
6a59e92db8
Set remaining message expiry interval when republishing.
7 years ago
85615c1bae
AUTH packet can be truncated.
7 years ago
f9a17e2782
Add alias support to the broker.
7 years ago
37727b402b
Fix maximum qos on listener conf.
7 years ago
8513af4da5
Tests and fixes for shortened DISCONNECT packets.
7 years ago
5f8d86b4ee
Fix sub-denied test.
7 years ago
326292681a
Add maximum-qos support to broker and client.
...
This comes in the form of:
* Per listener maximum_qos option, which can be in the range 0-2.
* Changes to mosquitto_publish*() to return MOSQ_ERR_QOS_NOT_SUPPORTED
if attempting to publish with a higher QoS than supported.
* Bridges will downgrade messages to match the maximum QoS.
More tests on the broker side (specifically bridges) are required. This
needs bridge support for MQTT 5 first.
7 years ago
740a128769
Support PUBREC reason code >=0x80 as partial qos2 flow.
7 years ago
84660e1cbe
Send maximum limits for QoS>0.
...
This needs more work on the broker front to simplify the design.
7 years ago
16e83bfe5d
Process receive maximum (as max_inflight_messages).
7 years ago
7c3666d593
Subscription identifier support.
7 years ago
dab6452a1d
Add test for duplicate CONNECT.
7 years ago
ec1178806c
Fix bridge tests.
7 years ago
fcf4cd0b27
Merge branch 'master' into mqtt5
7 years ago
31e6dbbe74
Tests and fixes for subscription options.
7 years ago
72fdb590b1
Fix no local and retain as published for local bridges.
7 years ago
2919510384
No local support.
7 years ago
db7901884f
Retain-as-published support.
7 years ago
89f3d7bb3f
Don't print connect/disconnect messages when connection_messages false.
...
Closes #772 . Closes #613 . Closes #537 .
Thanks to Christopher Maynard, Brandon Arrendondo, and qubeck.
7 years ago
a00dd29af8
Fix building where TLS-PSK is not available.
...
Closes #68 .
7 years ago
9097577b49
Fix acl_file being ignore for default listener if with per_listener_settings
...
Close #1073 . Thanks to Jef Driesen.
Bug: https://github.com/eclipse/mosquitto/issues/1073
7 years ago
1a6f8d3c28
src: ASN1_STRING_data is deprecated in OpenSSL 1.1
...
ASN1_STRING_get0_data replaces ASN1_STRING_data in OpenSSL 1.1 therefore
add an #ifdef for backwards compatibility.
Signed-off-by: Jelle van der Waa <jelle@vdwaa.nl>
7 years ago
f90ba23738
Retain handling support.
7 years ago
9896e61727
Test and small fix for response-topic and correlation-data props.
7 years ago
6ef2c79e9a
Add max_keepalive, for limiting keepalives of MQTT v5 clients.
7 years ago
48c2217015
auto_id_prefix now defaults to 'auto-'.
7 years ago
1d3949bce0
Improve broker generated client ids for the non-Linux case.
...
Removes libuuid dependency.
7 years ago
ead440e47d
bridge: fix issue where keepalive_interval gets added to restart_timeout using ADNS
...
Signed-off-by: Abilio Marques <abiliojr@gmail.com>
7 years ago
3a871828ac
Print message on error when installing as a Windows service.
7 years ago
c9ed2708f6
Don't reload auth_opt_ options on reload.
...
This matches the behaviour of the other plugin options.
Closes #1068 . Thanks to Jason McFadyen.
Bug: https://github.com/eclipse/mosquitto/issues/1068
7 years ago
464b12f3d6
Fix outgoing retained messages not being sent by bridges.
...
This now happens on initial connection, after CONNACK is processed,
before it was happening (and being dropped) before the connection was
made.
Closes #1040 . Thanks to giover.
Bug: https://github.com/eclipse/mosquitto/issues/1040
7 years ago
e169f1c7c2
When using ADNS, don't ask for all network protocols when connecting.
...
This can lead to confusing "Protocol not supported" errors if the
network is down, because UDP sockets are provided.
Thanks to jsaak.
Closes #1062 .
Bug: https://github.com/eclipse/mosquitto/issues/1062
7 years ago
d29dac087d
Add socket_domain option.
7 years ago
7020fad86c
Add server support for Assigned Client Identifier.
7 years ago
d5108956bf
Process session-expiry-interval on CONNECT and DISCONNECT.
...
Add test to check for invalid values.
7 years ago
54db895cb3
Rename clean_session to clean_start for v5.
7 years ago
1241f68ff5
Macro update
7 years ago
17d213b79a
Declare lack of support for shared subs and sub IDs.
7 years ago
9560c5bac7
Add retain_available support.
7 years ago
6ca746695f
Pass db to send__connack() to give it access to config.
7 years ago
9464e3fe19
Guard against possible null client id.
7 years ago
098a1c8ecf
Fix subscribe_multiple datatypes.
7 years ago
beb96c6b8b
Merge branch 'master' into develop
7 years ago
Roger A. Light
Sigmund Vik
Jasper Lievisse Adriaanse
Karl Palsson
Michael
Gianfranco Costamagna
Panagiotis Vasilikos
Matt Woelfel
YangHau
Matevz Mihalic
Christian von Arnim
John Hickey
Vinod Kumar
Pierre Fersing
Abilio Marques
Steven Lawrance
Nicolás Pernas Maradei
Jelle van der Waa