Roger A. Light
b544b46156
Update version.
6 years ago
Roger A. Light
b0a065f790
Update changelog. Release page. Bump copyright.
6 years ago
Roger A. Light
c2ec6f002e
Fix test to match fixed protocol check.
6 years ago
Roger A. Light
0c68c20d2b
Fix `mosquitto_client_protocol()` returning incorrect values.
6 years ago
Roger A. Light
db02c9162d
Add plugin that prints out calls, to help debugging.
6 years ago
Roger A. Light
032af6bf69
Add missing header
6 years ago
Roger A. Light
3ff0d04910
Update test key length to 2048 to avoid new openssl rejections.
6 years ago
Roger A. Light
b6a54a21d8
Remove duplicate code.
6 years ago
Roger A. Light
8d5fd7d1e2
Fix `mosquitto_topic_matches_sub()` behaviour with wildcards in topic.
...
It was not returning MOSQ_ERR_INVAL if the topic contains a wildcard.
Closes #1589 . Thanks to mdelete.
6 years ago
Roger A. Light
f16d9e2bcf
Add file missing from earlier commit.
6 years ago
Roger A. Light
c4e41f3444
Back port db_dump from develop.
...
Closes #1519 . Thanks to Christoph Krey.
6 years ago
Roger A. Light
2a8c1d03f5
Merge branch 'coverity-fixes' into fixes
6 years ago
Roger A. Light
17e20de9e7
Fix session-expiry-interval for v5 clients using -c.
...
Default behaviour for v5 clients using `-c` is now to use infinite length
sessions, as with v3 clients.
Closes #1546 . Thanks to Kiran Pradeep.
6 years ago
Gianfranco Costamagna
078ad752cd
cmake: add ADNS enable/disable dynamic support
...
Signed-off-by: Gianfranco Costamagna <costamagnagianfranco@yahoo.it>
6 years ago
Gianfranco Costamagna
e9a7150031
Bugfix: enabling DLT was overriding everything else on linker flags because of error in cmake set keyword
...
Signed-off-by: Gianfranco Costamagna <costamagnagianfranco@yahoo.it>
6 years ago
Gianfranco Costamagna
7a5c2d4da5
Bugfix: include "deps" directory only if BUNDLED_DEPS has been provided and set to true
...
Signed-off-by: Gianfranco Costamagna <costamagnagianfranco@yahoo.it>
6 years ago
Roger A. Light
56d0b950ac
Fix `--remove-retained` not obeying the `-T` option.
...
This means `--remove-retained -t bbc/# -T bbc/one/#` would remove all
retained messages in `bbc/#`, instead of leaving all of the topics in
`bbc/one/#`.
Closes #1585 . Thanks to Simon Moser.
6 years ago
Roger A. Light
3a89059271
Don't call SSL_shutdown() if SSL init hasn't completed.
6 years ago
Roger A. Light
07c54627e9
Print OpenSSL errors in more situations
...
Covers when loading certificates fails, or there are ENGINE problems.
Closes #1552 . Thanks to Michael Richardson.
6 years ago
Roger A. Light
27b4518d7e
Improve password file parsing in the broker and mosqitto_passwd.
...
Closes #1584 . Thanks to panava.
6 years ago
Roger A. Light
ed5db1bd6b
Fix `bind_interface` not working for the default listener.
...
Closes #1533 . Thanks to Markus Gothe.
6 years ago
Roger A. Light
e188a6b500
More whitespace trimming fixes/consolidation.
6 years ago
Roger A. Light
32969169f7
Trim whitespace from acl topics.
6 years ago
Roger A. Light
70fd600c3a
Fix trailing whitespace not being trimmed on acl users.
...
Closes #1539 . Thanks to CliveJL and LeonPoon.
6 years ago
Roger A. Light
9a0de5ef61
Free log_timestamp_format on exit.
...
Closes #1523 . Thanks to Basavesh Shivakumar.
6 years ago
Roger A. Light
81641df043
Expose net__print_ssl_error() prototype.
6 years ago
Roger A. Light
17db97584e
Fix client keepalive test using too low keepalive.
6 years ago
Roger A. Light
11ece604c4
Merge branch 'bugfix-MemLeak_in_handle_unsubscribe' of git://github.com/panava/mosquitto into panava-bugfix-MemLeak_in_handle_unsubscribe
6 years ago
Roger A. Light
89b55094c0
Merge branch 'bugfix-NullDeref_in_util_mosc.c' of git://github.com/panava/mosquitto into panava-bugfix-NullDeref_in_util_mosc.c
6 years ago
Roger A. Light
3220790790
Merge branch 'bugfix-MemoryLeak_in_persist_read' of git://github.com/panava/mosquitto into panava-bugfix-MemoryLeak_in_persist_read
6 years ago
Roger A. Light
08de10ae43
Distribute clients with 1.5 docker image.
...
Closes #1548 .
6 years ago
Roger A. Light
f67b3d4e98
Merge branch 'master' into fixes
6 years ago
Roger A. Light
50735afb5b
Fix for internal logging not printing.
6 years ago
Panagiotis Vasilikos
618413e1d2
Resource leak in persist_read.c
...
Reason: In lines 435 and 439, the function returns without calling closing
fptr which was opened at line 399.
Fix: I added fclose(fptr) statements before each of the returns.
Signed-off-by: Panagiotis Vasilikos <panagiotis.vasilikos@alexandra.dk>
6 years ago
Panagiotis Vasilikos
dd6d8237cb
Potential Null pointer dereference in util_mosq.c
...
Reason: There is no check that the mosquitto__malloc at line 162 was sucessfull.
This could result to a Null pointer dereference in the memcpy call at line 166.
Fix: I added the check.
Signed-off-by: Panagiotis Vasilikos <panagiotis.vasilikos@alexandra.dk>
6 years ago
Roger A. Light
8f1c8cba59
Set minimum keepalive argument to `mosquitto_connect*()` to be 5 seconds.
...
Closes #1550 . Thanks to Markus Gothe.
6 years ago
Roger A. Light
9ae38788dc
Fix config->user not being freed on exit.
...
Closes #1564 . Thanks to back1127.
6 years ago
Roger A. Light
812c0636d5
Satisfy valgrind when exiting on error.
...
This is when due to not being able to open a listening socket, solved by
calling freeaddrinfo in the error cases.
Closes #1565 . Thanks to back1127.
6 years ago
Roger A. Light
e7c9f009bd
Strip whitespace from end of config file string options.
...
Closes #1566 . Thanks to kollokollo.
6 years ago
Panagiotis Vasilikos
49bf788862
Memory leak in handle_unsubscribe.c
...
Reason: In line 70, the memory allocation for the pointer reasons_codes may
result to a memory leak due to the many returns (e.g as the one in line 78)
occuring in the program's path until reaching the mosquitto__free at line 122.
Fix: I added a mosquitto__free(reason_codes) statement before each return
statement that could result to a memory leak
Signed-off-by: Panagiotis Vasilikos <panagiotis.vasilikos@alexandra.dk>
6 years ago
Panagiotis Vasilikos
caeb211cc5
Memory leak in socks_mosq.c
...
Reason: The memory allocated for the packet pointer at line 155 is not freed
before returning at line 188.
Fix: I inserted the mosquitto__free(packet) statement just before returning
at line 188.
Signed-off-by: Panagiotis Vasilikos <panagiotis.vasilikos@alexandra.dk>
6 years ago
Panagiotis Vasilikos
0f7052564c
Memory leak in handle_unsubscribe.c
...
Reason: In line 70, the memory allocation for the pointer reasons_codes may
result to a memory leak due to the many returns (e.g as the one in line 78)
occuring in the program's path until reaching the mosquitto__free at line 122.
Fix: I moved the memory allocation code block (lines 69-73) just before
the line 102. This is the first place the pointer reason_codes is used, while
the following mosquitto__free operators free the allocated memory correctly.
Signed-off-by: Panagiotis Vasilikos <panagiotis.vasilikos@alexandra.dk>
6 years ago
Roger A. Light
4408339dbc
Make consts unsigned where they are compared against unsigned.
6 years ago
Roger A. Light
5528dde56a
Fix possible null dereferences.
6 years ago
Roger A. Light
05ec02b3f3
Remove dead values.
6 years ago
Roger A. Light
18f0508a6e
Fix dereference before null check.
...
Coverity Scan 1405815.
6 years ago
Roger A. Light
db62f9843f
Fix unused value being overwritten.
...
Coverity Scan 1400727.
6 years ago
Roger A. Light
6aa9b91fff
Add `testing` target for compiling test client fixes.
6 years ago
Roger A. Light
d452ea138b
Use presence of password file as indicator for authentication checks.
...
Previously, authentication checks would only take place if usernames
were defined in the password file.
Closes #1545 . Thanks to Timothy Godfrey.
6 years ago
Roger A. Light
b6119bb759
Check ACL patterns for validity when loading.
...
Closes #1539 . Thanks to Leon Poon.
6 years ago